Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3379439
D3980.id12460.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
973 B
Referenced Files
None
Subscribers
None
D3980.id12460.diff
View Options
diff --git a/web/modals/threads/thread-settings-general-tab.react.js b/web/modals/threads/thread-settings-general-tab.react.js
--- a/web/modals/threads/thread-settings-general-tab.react.js
+++ b/web/modals/threads/thread-settings-general-tab.react.js
@@ -1,6 +1,7 @@
// @flow
import * as React from 'react';
+import tinycolor from 'tinycolor2';
import {
changeThreadSettingsActionTypes,
@@ -51,8 +52,13 @@
}, [inputDisabled]);
const changeQueued: boolean = React.useMemo(
- () => Object.values(queuedChanges).some(v => v !== null && v !== undefined),
- [queuedChanges],
+ () =>
+ (queuedChanges.name !== null && queuedChanges.name !== undefined) ||
+ (queuedChanges.description !== null &&
+ queuedChanges.description !== undefined) ||
+ (!!queuedChanges.color &&
+ !tinycolor.equals(threadInfo.color, queuedChanges.color)),
+ [queuedChanges, threadInfo.color],
);
const onChangeName = React.useCallback(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Nov 28, 3:52 PM (19 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2594390
Default Alt Text
D3980.id12460.diff (973 B)
Attached To
Mode
D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop
Attached
Detach File
Event Timeline
Log In to Comment