Page MenuHomePhabricator
Files F3384079

D4045.id12689.diff
No OneTemporary
Actions

D4045.id12689.diff
View Options

diff --git a/web/modals/threads/notifications/notifications-option-info.react.js b/web/modals/threads/notifications/enum-settings-option-info.react.js
rename from web/modals/threads/notifications/notifications-option-info.react.js
rename to web/modals/threads/notifications/enum-settings-option-info.react.js
--- a/web/modals/threads/notifications/notifications-option-info.react.js
+++ b/web/modals/threads/notifications/enum-settings-option-info.react.js
@@ -11,7 +11,7 @@
+children: React.Node,
};
-function NotificationsOptionInfo(props: Props): React.Node {
+function EnumSettingsOptionInfo(props: Props): React.Node {
const { valid, children } = props;
const optionInfoClasses = React.useMemo(
@@ -34,4 +34,4 @@
);
}
-export default NotificationsOptionInfo;
+export default EnumSettingsOptionInfo;
diff --git a/web/modals/threads/notifications/notifications-option.react.js b/web/modals/threads/notifications/enum-settings-option.react.js
rename from web/modals/threads/notifications/notifications-option.react.js
rename to web/modals/threads/notifications/enum-settings-option.react.js
--- a/web/modals/threads/notifications/notifications-option.react.js
+++ b/web/modals/threads/notifications/enum-settings-option.react.js
@@ -4,8 +4,8 @@
import * as React from 'react';
import Radio from '../../../components/radio.react';
+import EnumSettingsOptionInfo from './enum-settings-option-info.react';
import css from './notifications-modal.css';
-import NotificationsOptionInfo from './notifications-option-info.react';
type Props = {
+selected: boolean,
@@ -15,15 +15,15 @@
+description: $ReadOnlyArray<[string, boolean]>,
};
-function NotificationsOption(props: Props): React.Node {
+function EnumSettingsOption(props: Props): React.Node {
const { icon, title, description, selected, onSelect } = props;
const descriptionItems = React.useMemo(
() =>
description.map(([text, isValid]) => (
- <NotificationsOptionInfo key={text} valid={isValid}>
+ <EnumSettingsOptionInfo key={text} valid={isValid}>
{text}
- </NotificationsOptionInfo>
+ </EnumSettingsOptionInfo>
)),
[description],
);
@@ -47,4 +47,4 @@
);
}
-export default NotificationsOption;
+export default EnumSettingsOption;
diff --git a/web/modals/threads/notifications/notifications-modal.react.js b/web/modals/threads/notifications/notifications-modal.react.js
--- a/web/modals/threads/notifications/notifications-modal.react.js
+++ b/web/modals/threads/notifications/notifications-modal.react.js
@@ -27,8 +27,8 @@
import Button from '../../../components/button.react';
import { useSelector } from '../../../redux/redux-utils';
import Modal from '../../modal.react';
+import EnumSettingsOption from './enum-settings-option.react';
import css from './notifications-modal.css';
-import NotificationsOption from './notifications-option.react';
type NotificationSettings = 'focused' | 'badge-only' | 'background';
@@ -85,7 +85,7 @@
/>
);
return (
- <NotificationsOption
+ <EnumSettingsOption
selected={isFocusedSelected}
title="Focused (enabled)"
description={description}
@@ -110,7 +110,7 @@
/>
);
return (
- <NotificationsOption
+ <EnumSettingsOption
selected={isFocusedBadgeOnlySelected}
title="Focused (badge only)"
description={description}
@@ -135,7 +135,7 @@
/>
);
return (
- <NotificationsOption
+ <EnumSettingsOption
selected={isBackgroundSelected}
title="Background"
description={description}

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 29, 7:16 PM (21 h, 30 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2597882
Default Alt Text
D4045.id12689.diff (3 KB)

Event Timeline