Page MenuHomePhabricator

D3900.diff
No OneTemporary

D3900.diff

diff --git a/native/navigation/overlay-navigator.react.js b/native/navigation/overlay-navigator.react.js
--- a/native/navigation/overlay-navigator.react.js
+++ b/native/navigation/overlay-navigator.react.js
@@ -251,6 +251,17 @@
const data = updatedSceneData[key];
invariant(data, `should have sceneData for dismissed key ${key}`);
+ if (!visibleOverlayEntryForNewScene(scene)) {
+ // This should only happen if TabNavigator gets dismissed
+ // TabNavigator doesn't normally ever get dismissed, but hot reload
+ // can cause that to happen. We don't need to animate TabNavigator
+ // closed, and in fact we would crash if we tried. So we short-circuit
+ // the logic below
+ delete updatedSceneData[key];
+ sceneDataChanged = true;
+ continue;
+ }
+
// A route just got dismissed
// We'll watch the animation to determine when to clear the screen
const { position } = data.context;

File Metadata

Mime Type
text/plain
Expires
Tue, Dec 3, 2:15 PM (2 h, 5 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2611953
Default Alt Text
D3900.diff (1015 B)

Event Timeline