Page MenuHomePhabricator

D6307.diff
No OneTemporary

D6307.diff

diff --git a/lib/shared/messages/reaction-message-spec.js b/lib/shared/messages/reaction-message-spec.js
--- a/lib/shared/messages/reaction-message-spec.js
+++ b/lib/shared/messages/reaction-message-spec.js
@@ -202,12 +202,16 @@
messageData: ReactionMessageData,
params: GeneratesNotifsParams,
) => {
+ const { action } = rawMessageInfo;
const { notifTargetUserID, fetchMessageInfoByID } = params;
+
const targetMessageInfo = await fetchMessageInfoByID(
rawMessageInfo.targetMessageID,
);
- return targetMessageInfo?.creatorID === notifTargetUserID
- ? pushTypes.NOTIF
- : undefined;
+
+ if (targetMessageInfo?.creatorID !== notifTargetUserID) {
+ return undefined;
+ }
+ return action === 'add_reaction' ? pushTypes.NOTIF : pushTypes.RESCIND;
},
});

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 7:03 AM (20 h, 46 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2680866
Default Alt Text
D6307.diff (821 B)

Event Timeline