Page MenuHomePhabricator
Files F3498455

D14127.id46346.diff
No OneTemporary
Actions

D14127.id46346.diff
View Options

diff --git a/native/chat/multimedia-message-tooltip-button.react.js b/native/chat/multimedia-message-tooltip-button.react.js
--- a/native/chat/multimedia-message-tooltip-button.react.js
+++ b/native/chat/multimedia-message-tooltip-button.react.js
@@ -5,6 +5,7 @@
type SharedValue,
useAnimatedStyle,
interpolate,
+ Extrapolate,
} from 'react-native-reanimated';
import { chatMessageItemHasEngagement } from 'lib/shared/chat-message-item-utils.js';
@@ -28,14 +29,11 @@
import { useTooltipActions } from '../tooltip/tooltip-hooks.js';
import type { TooltipRoute } from '../tooltip/tooltip.react.js';
-const { Node, Extrapolate } = Animated;
-
function noop() {}
type Props = {
+navigation: AppNavigationProp<'MultimediaMessageTooltipModal'>,
+route: TooltipRoute<'MultimediaMessageTooltipModal'>,
- +progress: Node,
+progressV2: SharedValue<number>,
+isOpeningSidebar: boolean,
};
diff --git a/native/chat/robotext-message-tooltip-button.react.js b/native/chat/robotext-message-tooltip-button.react.js
--- a/native/chat/robotext-message-tooltip-button.react.js
+++ b/native/chat/robotext-message-tooltip-button.react.js
@@ -5,6 +5,7 @@
type SharedValue,
interpolate,
useAnimatedStyle,
+ Extrapolate,
} from 'react-native-reanimated';
import { chatMessageItemEngagementTargetMessageInfo } from 'lib/shared/chat-message-item-utils.js';
@@ -26,12 +27,9 @@
import { useTooltipActions } from '../tooltip/tooltip-hooks.js';
import type { TooltipRoute } from '../tooltip/tooltip.react.js';
-const { Node, Extrapolate } = Animated;
-
type Props = {
+navigation: AppNavigationProp<'RobotextMessageTooltipModal'>,
+route: TooltipRoute<'RobotextMessageTooltipModal'>,
- +progress: Node,
+progressV2: SharedValue<number>,
...
};
diff --git a/native/chat/text-message-tooltip-button.react.js b/native/chat/text-message-tooltip-button.react.js
--- a/native/chat/text-message-tooltip-button.react.js
+++ b/native/chat/text-message-tooltip-button.react.js
@@ -5,6 +5,7 @@
type SharedValue,
useAnimatedStyle,
interpolate,
+ Extrapolate,
} from 'react-native-reanimated';
import { chatMessageItemHasEngagement } from 'lib/shared/chat-message-item-utils.js';
@@ -30,12 +31,9 @@
import { useTooltipActions } from '../tooltip/tooltip-hooks.js';
import type { TooltipRoute } from '../tooltip/tooltip.react.js';
-const { Node, Extrapolate } = Animated;
-
type Props = {
+navigation: AppNavigationProp<'TextMessageTooltipModal'>,
+route: TooltipRoute<'TextMessageTooltipModal'>,
- +progress: Node,
+progressV2: SharedValue<number>,
+isOpeningSidebar: boolean,
};
diff --git a/native/tooltip/tooltip.react.js b/native/tooltip/tooltip.react.js
--- a/native/tooltip/tooltip.react.js
+++ b/native/tooltip/tooltip.react.js
@@ -10,11 +10,12 @@
Platform,
Keyboard,
} from 'react-native';
-import Animated, {
+import {
interpolate,
useAnimatedStyle,
useSharedValue,
type SharedValue,
+ Extrapolate,
} from 'react-native-reanimated';
import {
@@ -44,8 +45,6 @@
type AnimatedStyleObj,
} from '../types/styles.js';
-const { Node, Extrapolate } = Animated;
-
const unboundStyles = {
backdrop: {
backgroundColor: 'black',
@@ -136,7 +135,6 @@
};
type ButtonProps<Base> = {
...Base,
- +progress: Node,
+progressV2: SharedValue<number>,
+isOpeningSidebar: boolean,
};
@@ -240,8 +238,7 @@
}, [getMargin, getTooltipHeight, params, tooltipLocation]);
invariant(overlayContext, 'Tooltip should have OverlayContext');
- const { position, positionV2 } = overlayContext;
- invariant(position, 'position should be defined in tooltip');
+ const { positionV2 } = overlayContext;
invariant(positionV2, 'position should be defined in tooltip');
const tooltipHorizontalOffset = useSharedValue(0);
@@ -474,7 +471,6 @@
const buttonProps: ButtonProps<BaseTooltipPropsType> = {
...navAndRouteForFlow,
- progress: position,
progressV2: positionV2,
isOpeningSidebar,
};

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 9:12 PM (1 h, 19 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2683141
Default Alt Text
D14127.id46346.diff (3 KB)

Event Timeline