Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3500729
D6222.id20766.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D6222.id20766.diff
View Options
diff --git a/keyserver/src/creators/message-creator.js b/keyserver/src/creators/message-creator.js
--- a/keyserver/src/creators/message-creator.js
+++ b/keyserver/src/creators/message-creator.js
@@ -49,7 +49,7 @@
>,
+threadIDs: Set<string>,
+notFocusedThreadIDs: Set<string>,
- +subthreadsCanNotify: Set<string>,
+ +userNotMemberOfSubthreads: Set<string>,
+subthreadsCanSetToUnread: Set<string>,
};
@@ -319,7 +319,7 @@
devices: new Map(),
threadIDs: new Set(),
notFocusedThreadIDs: new Set(),
- subthreadsCanNotify: new Set(),
+ userNotMemberOfSubthreads: new Set(),
subthreadsCanSetToUnread: new Set(),
};
perUserInfo.set(userID, thisUserInfo);
@@ -344,7 +344,7 @@
!isSubthreadMember ||
!permissionLookup(subthreadPermissions, threadPermissions.VISIBLE)
) {
- thisUserInfo.subthreadsCanNotify.add(subthread);
+ thisUserInfo.userNotMemberOfSubthreads.add(subthread);
}
}
}
@@ -366,7 +366,7 @@
const latestMessagesPerUser: LatestMessagesPerUser = new Map();
for (const pair of perUserInfo) {
const [userID, preUserPushInfo] = pair;
- const { subthreadsCanNotify } = preUserPushInfo;
+ const { userNotMemberOfSubthreads } = preUserPushInfo;
const userPushInfo = {
devices: [...preUserPushInfo.devices.values()],
messageInfos: [],
@@ -380,7 +380,7 @@
const { type } = messageInfo;
if (
(messageInfo.type !== messageTypes.CREATE_SUB_THREAD ||
- subthreadsCanNotify.has(messageInfo.childThreadID)) &&
+ userNotMemberOfSubthreads.has(messageInfo.childThreadID)) &&
messageSpecs[type].generatesNotifs &&
messageInfo.creatorID !== userID
) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 2:32 AM (17 h, 6 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2682788
Default Alt Text
D6222.id20766.diff (1 KB)
Attached To
Mode
D6222: [keyserver] Rename subthreadsCanNotify to userNotMemberOfSubthreads
Attached
Detach File
Event Timeline
Log In to Comment