Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3513263
D6867.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
956 B
Referenced Files
None
Subscribers
None
D6867.diff
View Options
diff --git a/keyserver/src/push/send.js b/keyserver/src/push/send.js
--- a/keyserver/src/push/send.js
+++ b/keyserver/src/push/send.js
@@ -136,11 +136,16 @@
username &&
threadInfo.currentUser.role &&
oldValidUsernameRegex.test(username) &&
- newMessageInfos.some(
- newMessageInfo =>
- newMessageInfo.type === messageTypes.TEXT &&
- isMentioned(username, newMessageInfo.text),
- );
+ newMessageInfos.some(newMessageInfo => {
+ const unwrappedMessageInfo =
+ newMessageInfo.type === messageTypes.SIDEBAR_SOURCE
+ ? newMessageInfo.sourceMessage
+ : newMessageInfo;
+ return (
+ unwrappedMessageInfo.type === messageTypes.TEXT &&
+ isMentioned(username, unwrappedMessageInfo.text)
+ );
+ });
if (!updateBadge && !displayBanner && !userWasMentioned) {
continue;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 11:28 PM (12 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2692861
Default Alt Text
D6867.diff (956 B)
Attached To
Mode
D6867: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override
Attached
Detach File
Event Timeline
Log In to Comment