Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3517763
D9049.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D9049.diff
View Options
diff --git a/lib/selectors/socket-selectors.js b/lib/selectors/socket-selectors.js
--- a/lib/selectors/socket-selectors.js
+++ b/lib/selectors/socket-selectors.js
@@ -131,31 +131,13 @@
}
const { failUnmentioned } = serverRequest;
- if (failUnmentioned && failUnmentioned.threadInfos) {
- for (const threadID in convertedInfos[
- stateSyncSpecs.threads.hashKey
- ]) {
- const key = `threadInfo|${threadID}`;
- const hashResult = hashResults[key];
- if (hashResult === null || hashResult === undefined) {
- hashResults[key] = false;
- }
+ for (const spec of values(specPerInnerHashKey)) {
+ const innerHashKey = spec.innerHashSpec?.hashKey;
+ if (!failUnmentioned?.[spec.hashKey] || !innerHashKey) {
+ continue;
}
- }
- if (failUnmentioned && failUnmentioned.entryInfos) {
- for (const entryID in convertedInfos[
- stateSyncSpecs.entries.hashKey
- ]) {
- const key = `entryInfo|${entryID}`;
- const hashResult = hashResults[key];
- if (hashResult === null || hashResult === undefined) {
- hashResults[key] = false;
- }
- }
- }
- if (failUnmentioned && failUnmentioned.userInfos) {
- for (const userID in convertedInfos[stateSyncSpecs.users.hashKey]) {
- const key = `userInfo|${userID}`;
+ for (const id in convertedInfos[spec.hashKey]) {
+ const key = `${innerHashKey}|${id}`;
const hashResult = hashResults[key];
if (hashResult === null || hashResult === undefined) {
hashResults[key] = false;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 6:13 PM (18 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2695720
Default Alt Text
D9049.diff (1 KB)
Attached To
Mode
D9049: [lib] Refactor the remaining part of the hash logic using specs
Attached
Detach File
Event Timeline
Log In to Comment