Page MenuHomePhabricator
Files F3523056

D5608.id18357.diff
No OneTemporary
Actions

D5608.id18357.diff
View Options

diff --git a/services/blob/src/DatabaseManager.cpp b/services/blob/src/DatabaseManager.cpp
--- a/services/blob/src/DatabaseManager.cpp
+++ b/services/blob/src/DatabaseManager.cpp
@@ -40,7 +40,7 @@
request.AddKey(
BlobItem::FIELD_BLOB_HASH,
Aws::DynamoDB::Model::AttributeValue(blobHash));
- return std::move(this->innerFindItem<BlobItem>(request));
+ return this->innerFindItem<BlobItem>(request);
}
void DatabaseManager::removeBlobItem(const std::string &blobHash) {
@@ -76,7 +76,7 @@
ReverseIndexItem::FIELD_HOLDER,
Aws::DynamoDB::Model::AttributeValue(holder));
- return std::move(this->innerFindItem<ReverseIndexItem>(request));
+ return this->innerFindItem<ReverseIndexItem>(request);
}
std::vector<std::shared_ptr<database::ReverseIndexItem>>
diff --git a/services/lib/src/DatabaseManagerBase.h b/services/lib/src/DatabaseManagerBase.h
--- a/services/lib/src/DatabaseManagerBase.h
+++ b/services/lib/src/DatabaseManagerBase.h
@@ -48,7 +48,7 @@
return nullptr;
}
item->assignItemFromDatabase(outcomeItem);
- return std::move(item);
+ return item;
}
} // namespace database
diff --git a/services/tunnelbroker/src/libcpp/src/Database/DatabaseManager.cpp b/services/tunnelbroker/src/libcpp/src/Database/DatabaseManager.cpp
--- a/services/tunnelbroker/src/libcpp/src/Database/DatabaseManager.cpp
+++ b/services/tunnelbroker/src/libcpp/src/Database/DatabaseManager.cpp
@@ -67,7 +67,7 @@
request.AddKey(
DeviceSessionItem::FIELD_SESSION_ID,
Aws::DynamoDB::Model::AttributeValue(sessionID));
- return std::move(this->innerFindItem<DeviceSessionItem>(request));
+ return this->innerFindItem<DeviceSessionItem>(request);
}
void DatabaseManager::removeSessionItem(const std::string &sessionID) {
@@ -176,7 +176,7 @@
request.AddKey(
SessionSignItem::FIELD_DEVICE_ID,
Aws::DynamoDB::Model::AttributeValue(deviceID));
- return std::move(this->innerFindItem<SessionSignItem>(request));
+ return this->innerFindItem<SessionSignItem>(request);
}
void DatabaseManager::removeSessionSignItem(const std::string &deviceID) {
@@ -205,7 +205,7 @@
request.AddKey(
PublicKeyItem::FIELD_DEVICE_ID,
Aws::DynamoDB::Model::AttributeValue(deviceID));
- return std::move(this->innerFindItem<PublicKeyItem>(request));
+ return this->innerFindItem<PublicKeyItem>(request);
}
void DatabaseManager::removePublicKeyItem(const std::string &deviceID) {
@@ -282,7 +282,7 @@
request.AddKey(
MessageItem::FIELD_MESSAGE_ID,
Aws::DynamoDB::Model::AttributeValue(messageID));
- return std::move(this->innerFindItem<MessageItem>(request));
+ return this->innerFindItem<MessageItem>(request);
}
std::vector<std::shared_ptr<MessageItem>>

File Metadata

Mime Type
text/plain
Expires
Tue, Dec 24, 8:15 AM (20 h, 12 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2698365
Default Alt Text
D5608.id18357.diff (2 KB)

Event Timeline