Page MenuHomePhabricator
Files F3528781

D13756.id45551.diff
No OneTemporary
Actions

D13756.id45551.diff
View Options

diff --git a/keyserver/src/responders/farcaster-webhook-responders.js b/keyserver/src/responders/farcaster-webhook-responders.js
--- a/keyserver/src/responders/farcaster-webhook-responders.js
+++ b/keyserver/src/responders/farcaster-webhook-responders.js
@@ -1,19 +1,38 @@
// @flow
+import { createHmac } from 'crypto';
import type { $Request } from 'express';
+import { type NeynarWebhookCastCreatedEvent } from 'lib/types/farcaster-types.js';
import { neynarWebhookCastCreatedEventValidator } from 'lib/types/validators/farcaster-webhook-validators.js';
+import { ServerError } from 'lib/utils/errors.js';
import { assertWithValidator } from 'lib/utils/validation-utils.js';
+import { getNeynarConfig } from '../utils/neynar-utils.js';
+
const taggedCommFarcasterInputValidator =
neynarWebhookCastCreatedEventValidator;
const threadHashTagRegex = /\B#createathread\b/i;
-async function taggedCommFarcasterResponder(request: $Request): Promise<void> {
- const event = assertWithValidator(
- request.body,
- taggedCommFarcasterInputValidator,
- );
+async function verifyNeynarWebhookSignature(
+ signature: string,
+ event: NeynarWebhookCastCreatedEvent,
+): Promise<boolean> {
+ const neynarSecret = await getNeynarConfig();
+ if (!neynarSecret?.neynarWebhookSecret) {
+ throw new ServerError('missing_webhook_secret');
+ }
+
+ const hmac = createHmac('sha512', neynarSecret.neynarWebhookSecret);
+ hmac.update(JSON.stringify(event));
+
+ return hmac.digest('hex') === signature;
+}
+
+async function taggedCommFarcasterResponder(req: $Request): Promise<void> {
+ const { body } = req;
+
+ const event = assertWithValidator(body, taggedCommFarcasterInputValidator);
const { text: eventText } = event.data;
const foundCreateThreadHashTag = threadHashTagRegex.test(eventText);
@@ -22,7 +41,15 @@
return;
}
- console.log(event);
+ const signature = req.header('X-Neynar-Signature');
+ if (!signature) {
+ throw new ServerError('missing_neynar_signature');
+ }
+
+ const isValidSignature = await verifyNeynarWebhookSignature(signature, event);
+ if (!isValidSignature) {
+ throw new ServerError('invalid_webhook_signature');
+ }
}
export { taggedCommFarcasterResponder, taggedCommFarcasterInputValidator };

File Metadata

Mime Type
text/plain
Expires
Wed, Dec 25, 10:19 AM (4 h, 54 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2702514
Default Alt Text
D13756.id45551.diff (2 KB)

Event Timeline