Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3531586
D3190.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D3190.diff
View Options
diff --git a/web/chat/thread-menu.react.js b/web/chat/thread-menu.react.js
--- a/web/chat/thread-menu.react.js
+++ b/web/chat/thread-menu.react.js
@@ -1,10 +1,17 @@
// @flow
-import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
+import {
+ faArrowRight,
+ faBell,
+ faCog,
+ faUserFriends,
+} from '@fortawesome/free-solid-svg-icons';
import * as React from 'react';
-import { type ThreadInfo } from 'lib/types/thread-types';
+import { childThreadInfos } from 'lib/selectors/thread-selectors';
+import { type ThreadInfo, threadTypes } from 'lib/types/thread-types';
+import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css';
@@ -16,9 +23,34 @@
function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false);
- // eslint-disable-next-line no-unused-vars
const { threadInfo } = props;
+ const membersItem = React.useMemo(() => {
+ if (threadInfo.type === threadTypes.PERSONAL) {
+ return null;
+ }
+ return <ThreadMenuItem key="members" text="Members" icon={faUserFriends} />;
+ }, [threadInfo.type]);
+
+ const childThreads = useSelector(
+ state => childThreadInfos(state)[threadInfo.id],
+ );
+
+ const hasSidebars = React.useMemo(() => {
+ return childThreads?.some(
+ childThreadInfo => childThreadInfo.type === threadTypes.SIDEBAR,
+ );
+ }, [childThreads]);
+
+ const sidebarItem = React.useMemo(() => {
+ if (!hasSidebars) {
+ return null;
+ }
+ return (
+ <ThreadMenuItem key="sidebars" text="Sidebars" icon={faArrowRight} />
+ );
+ }, [hasSidebars]);
+
const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
@@ -26,9 +58,9 @@
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
- const items = [settingsItem, notificationsItem];
+ const items = [settingsItem, notificationsItem, membersItem, sidebarItem];
return items.filter(Boolean);
- }, []);
+ }, [membersItem, sidebarItem]);
const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Dec 26, 7:48 AM (12 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2704355
Default Alt Text
D3190.diff (2 KB)
Attached To
Mode
D3190: [web] Introduce `Members` and `Sidebars` thread menu actions
Attached
Detach File
Event Timeline
Log In to Comment