Page MenuHomePhabricator
Files F3558424

D3762.diff
No OneTemporary
Actions

D3762.diff
View Options

diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -94,6 +94,7 @@
+setCurrentTabType: SetState<TabType>,
+queuedChanges: ThreadChanges,
+setQueuedChanges: SetState<ThreadChanges>,
+ +namePlaceholder: string,
};
class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement;
@@ -153,14 +154,6 @@
: this.props.threadInfo[key];
}
- namePlaceholder() {
- return robotextName(
- this.props.threadInfo,
- this.props.viewerID,
- this.props.userInfos,
- );
- }
-
changeQueued() {
return (
Object.keys(
@@ -184,7 +177,7 @@
mainContent = (
<ThreadSettingsGeneralTab
threadNameValue={firstLine(this.possiblyChangedValue('name'))}
- threadNamePlaceholder={this.namePlaceholder()}
+ threadNamePlaceholder={this.props.namePlaceholder}
threadNameOnChange={this.onChangeName}
threadNameDisabled={inputDisabled}
threadNameInputRef={this.nameInputRef}
@@ -456,6 +449,11 @@
Object.freeze({}),
);
+ const namePlaceholder: string = React.useMemo(() => {
+ invariant(threadInfo, 'threadInfo should exist in namePlaceholder');
+ return robotextName(threadInfo, viewerID, userInfos);
+ }, [threadInfo, userInfos, viewerID]);
+
if (!threadInfo) {
return (
<Modal onClose={modalContext.clearModal} name="Invalid thread">
@@ -485,6 +483,7 @@
setCurrentTabType={setCurrentTabType}
queuedChanges={queuedChanges}
setQueuedChanges={setQueuedChanges}
+ namePlaceholder={namePlaceholder}
/>
);
},

File Metadata

Mime Type
text/plain
Expires
Sat, Dec 28, 3:00 AM (7 h, 13 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2723586
Default Alt Text
D3762.diff (1 KB)

Event Timeline