Page MenuHomePhabricator
Differential D4001 Diff 13076 native/chat/composed-message.react.js

Changeset View

Standalone View

View Options

native/chat/composed-message.react.js

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines const messageBox = (
{children} {children}
</AnimatedView> </AnimatedView>
</SwipeableMessage> </SwipeableMessage>
</View> </View>
); );
let inlineSidebar = null; let inlineSidebar = null;
if (item.threadCreatedFromMessage) { if (item.threadCreatedFromMessage) {
const position = isViewer ? 'right' : 'left';
ashoatUnsubmitted
Not Done
Inline Actions

Why is this necessary now but wasn't before?

ashoat: Why is this necessary now but wasn't before?
benschacAuthorUnsubmitted
Done
Inline Actions

I ended up removing it in a previous diff: https://phabricator.ashoat.com/D3971 because there was a comment about removing positioning, which both you and @atul suggested.

And, made sense at the time. I was removing all of the stylings in relation to the component that was there before. So, those position props did nothing.

Now the new styling has been introduced, and we need to absolutely position each one of these components differently right and left or viewer and sender positions.

benschac: I ended up removing it in a previous diff: https://phabricator.ashoat.com/D3971 because there…
ashoatUnsubmitted
Not Done
Inline Actions

Got it, thanks for clarifying!

ashoat: Got it, thanks for clarifying!
inlineSidebar = ( inlineSidebar = (
<View style={styles.inlineSidebar}> <View style={styles.inlineSidebar}>
<InlineSidebar threadInfo={item.threadCreatedFromMessage} /> <InlineSidebar
threadInfo={item.threadCreatedFromMessage}
position={position}
/>
</View> </View>
); );
} }
return ( return (
<View {...viewProps}> <View {...viewProps}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}> <AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<MessageHeader item={item} focused={focused} display="lowContrast" /> <MessageHeader item={item} focused={focused} display="lowContrast" />
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines