Changeset View
Standalone View
web/modals/threads/create/steps/subchannel-members.css
- This file was added.
.members { | |||||
overflow-y: auto; | |||||
} | |||||
.searchBar { | |||||
background-color: var(--modal-bg); | |||||
position: sticky; | |||||
tomek: Is there a good reason for using sticky? Can't it be just always at the top? What are the… | |||||
tomekUnsubmitted Not Done Inline ActionsThe sticky position is still used... why do we need it? tomek: The sticky position is still used... why do we need it? | |||||
jakubAuthorUnsubmitted Done Inline ActionsI put a reply in the previous update, but it seems that it disappeared. Using position: sticky here allow us to keep searchbar always on the top of the modal. Other solutions could require some changes in structure of the component. I tried to avoid nesting a scrollable component in another scrollable component, thus using sticky here seems to be the simplest solution. Here is a sample video that show the benefits of using it here: So, I guess using sticky here is benefitable. jakub: I put a reply in the previous update, but it seems that it disappeared.
Using `position… | |||||
tomekUnsubmitted Not Done Inline Actionssticky provides sticky behavior (so the component could be at the top or lower, but never above the viewport). In this case we want it to always be at the top, so this position isn't necessary and there are other ways of achieving the desired result. We should definitely replace it, but given the short time period, you can create a task to address this. tomek: `sticky` provides sticky behavior (so the component could be at the top or lower, but never… | |||||
padding: 2.5px 0; | |||||
top: 0; | |||||
} |
Is there a good reason for using sticky? Can't it be just always at the top? What are the benefits of using sticky here?