Page MenuHomePhabricator
Differential D6997 Diff 23515 lib/types/rust-binding-types.js

Changeset View

Standalone View

View Options

lib/types/rust-binding-types.js

Show All 9 Lines
declare class TunnelbrokerClientClass { declare class TunnelbrokerClientClass {
constructor( constructor(
deviceId: string, deviceId: string,
onReceiveCallback: tunnelbrokerOnReceiveCallback, onReceiveCallback: tunnelbrokerOnReceiveCallback,
): TunnelbrokerClientClass; ): TunnelbrokerClientClass;
publish(toDeviceId: string, payload: string): Promise<void>; publish(toDeviceId: string, payload: string): Promise<void>;
} }
type userComparisonResult = {
ashoatUnsubmitted
Done
Inline Actions
publish(toDeviceId: string, payload: string): Promise<void>;
}
- type userComparisonResult = {
+ type UserComparisonResult = {
+usersMissingFromKeyserver: Array<string>,

Types are always capitalized

ashoat: Types are always capitalized
+usersMissingFromKeyserver: Array<string>,
+usersMissingFromIdentity: Array<string>,
ashoatUnsubmitted
Done
Inline Actions
type userComparisonResult = {
- +usersMissingFromKeyserver: Array<string>,
- +usersMissingFromIdentity: Array<string>,
+ +usersMissingFromKeyserver: $ReadOnlyArray<string>,
+ +usersMissingFromIdentity: $ReadOnlyArray<string>,
};
type RustNativeBindingAPI = {

We should generally use $ReadOnlyArray unless we have a good reason not to, especially when it's in combination with + (read-only access modifier)

ashoat: We should generally use `$ReadOnlyArray` unless we have a good reason not to, especially when…
};
type RustNativeBindingAPI = { type RustNativeBindingAPI = {
+registerUser: ( +registerUser: (
userId: string, userId: string,
signingPublicKey: string, signingPublicKey: string,
username: string, username: string,
password: string, password: string,
sessionInitializationInfo: SignedIdentityKeysBlob, sessionInitializationInfo: SignedIdentityKeysBlob,
) => Promise<string>, ) => Promise<string>,
+loginUserPake: ( +loginUserPake: (
userId: string, userId: string,
signingPublicKey: string, signingPublicKey: string,
password: string, password: string,
sessionInitializationInfo: SignedIdentityKeysBlob, sessionInitializationInfo: SignedIdentityKeysBlob,
) => Promise<string>, ) => Promise<string>,
+loginUserWallet: ( +loginUserWallet: (
userId: string, userId: string,
signingPublicKey: string, signingPublicKey: string,
siweMessage: string, siweMessage: string,
siweSignature: string, siweSignature: string,
sessionInitializationInfo: SignedIdentityKeysBlob, sessionInitializationInfo: SignedIdentityKeysBlob,
socialProof: string, socialProof: string,
) => Promise<string>, ) => Promise<string>,
+deleteUser: (userId: string) => Promise<boolean>, +deleteUser: (userId: string) => Promise<boolean>,
+updateUser: (userId: string, password: string) => Promise<string>, +updateUser: (userId: string, password: string) => Promise<string>,
+compareUsers: (
userIds: $ReadOnlyArray<string>,
) => Promise<userComparisonResult>,
+TunnelbrokerClient: Class<TunnelbrokerClientClass>, +TunnelbrokerClient: Class<TunnelbrokerClientClass>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };