Page MenuHomePhabricator

[keyserver] add new compareUsers function to rust-node-addon
ClosedPublic

Authored by varun on Mar 7 2023, 10:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 6:45 PM
Unknown Object (File)
Wed, Feb 28, 6:40 PM
Unknown Object (File)
Wed, Feb 28, 6:24 PM
Unknown Object (File)
Wed, Feb 28, 5:43 PM
Unknown Object (File)
Mon, Feb 26, 7:27 AM
Unknown Object (File)
Tue, Feb 20, 11:41 PM
Unknown Object (File)
Tue, Feb 20, 11:40 PM
Unknown Object (File)
Tue, Feb 20, 11:40 PM
Subscribers

Details

Summary

adding a new function that just calls the compareUsers RPC and returns a userComparisonResult, containing two arrays: usersMissingFromKeyserver and usersMissingFromIdentity

Depends on D6984

Test Plan

this gets tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added 1 blocking reviewer(s): jon.

JS looks good with some minor nits. Somebody should look at Rust

lib/types/rust-binding-types.js
18 ↗(On Diff #23515)

Types are always capitalized

19–20 ↗(On Diff #23515)

We should generally use $ReadOnlyArray unless we have a good reason not to, especially when it's in combination with + (read-only access modifier)

keyserver/addons/rust-node-addon/src/identity_client/compare_users.rs
18 ↗(On Diff #23515)

Personal nit: but I would love for some white space to break up logical sections. Here we have "setup" and "action"

This revision is now accepted and ready to land.Mar 7 2023, 11:02 AM
This revision was automatically updated to reflect the committed changes.
varun marked 3 inline comments as done.