Page MenuHomePhabricator

[keyserver] add new compareUsers function to rust-node-addon

Authored by varun on Tue, Mar 7, 10:07 AM.
Referenced Files
Unknown Object (File)
Sat, Mar 25, 3:28 PM
Unknown Object (File)
Fri, Mar 24, 3:10 PM
Unknown Object (File)
Tue, Mar 21, 7:25 AM
Unknown Object (File)
Thu, Mar 16, 6:42 AM
Unknown Object (File)
Sun, Mar 12, 9:06 AM
Unknown Object (File)
Sun, Mar 12, 9:06 AM
Unknown Object (File)
Sun, Mar 12, 9:06 AM
Unknown Object (File)
Sat, Mar 11, 2:15 PM



adding a new function that just calls the compareUsers RPC and returns a userComparisonResult, containing two arrays: usersMissingFromKeyserver and usersMissingFromIdentity

Depends on D6984

Test Plan

this gets tested in the next diff

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

ashoat added 1 blocking reviewer(s): jon.

JS looks good with some minor nits. Somebody should look at Rust

18 ↗(On Diff #23515)

Types are always capitalized

19–20 ↗(On Diff #23515)

We should generally use $ReadOnlyArray unless we have a good reason not to, especially when it's in combination with + (read-only access modifier)

18 ↗(On Diff #23515)

Personal nit: but I would love for some white space to break up logical sections. Here we have "setup" and "action"

This revision is now accepted and ready to land.Tue, Mar 7, 11:02 AM
This revision was automatically updated to reflect the committed changes.
varun marked 3 inline comments as done.