Page MenuHomePhabricator

jon (Jonathan Ringer)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Jan 24 2022, 7:38 AM (130 w, 1 d)
Roles
Disabled

Recent Activity

Nov 6 2023

ashoat defrocked jon.
Nov 6 2023, 7:10 AM

Sep 3 2023

jon closed D9059: [Identity] Add uploadOneTimeKeys to auth service.
Sep 3 2023, 6:05 PM
jon committed rCOMMfeb17195f145: [Identity] Add uploadOneTimeKeys to auth service (authored by jon).
[Identity] Add uploadOneTimeKeys to auth service
Sep 3 2023, 6:05 PM
jon added a comment to D9059: [Identity] Add uploadOneTimeKeys to auth service.

Also, are you going to remove upload_one_time_keys() from unauthenticated client service?

Sep 3 2023, 5:58 PM
jon accepted D9065: [backup] Make blob url configurable with env var.
Sep 3 2023, 5:49 PM
jon accepted D9064: [backup] Add health endpoint.
Sep 3 2023, 5:49 PM
jon accepted D9063: [backup] Update backup dockerfile.
Sep 3 2023, 5:49 PM

Aug 31 2023

jon requested review of D9059: [Identity] Add uploadOneTimeKeys to auth service.
Aug 31 2023, 8:59 PM
jon requested review of D9058: [Identity] Use clap for argument parsing.
Aug 31 2023, 8:30 PM

Aug 30 2023

jon requested review of D9033: [Tunnelbroker] Add readme.
Aug 30 2023, 1:38 PM
jon closed D9015: [shared/grpc_clients] Add verify_user_access_token().
Aug 30 2023, 1:22 PM
jon committed rCOMM8a4af7fd5fb7: [shared/grpc_clients] Add verify_user_access_token() (authored by jon).
[shared/grpc_clients] Add verify_user_access_token()
Aug 30 2023, 1:22 PM
jon added a reviewer for D8957: [Keyserver] Use getCommConfig for tunnelbroker connection: ashoat.
Aug 30 2023, 1:01 PM
jon closed D8843: [Nix] Update nixpkgs.
Aug 30 2023, 12:50 PM
jon committed rCOMMffc458d606d8: [Nix] Update nixpkgs (authored by jon).
[Nix] Update nixpkgs
Aug 30 2023, 12:50 PM
jon accepted D9032: [identity] some clean up.
Aug 30 2023, 12:37 PM
jon added inline comments to D8918: [Tunnelbroker] Authenticate connecting devices.
Aug 30 2023, 9:06 AM
jon updated the diff for D9015: [shared/grpc_clients] Add verify_user_access_token().

Rebase on top of master

Aug 30 2023, 9:03 AM
jon accepted D9019: [backup] Update db constants.
Aug 30 2023, 8:22 AM
jon accepted D9017: [backup] Cleanup utils.
Aug 30 2023, 8:21 AM
jon added a comment to D9016: [backup] Improve attachment handling.

Mostly looks good to me, let someone else review

Aug 30 2023, 7:46 AM
jon abandoned D9014: [Commtest] Remove backup gRPC tests.

https://phab.comm.dev/D8966 seems like the right approach. Closing

Aug 30 2023, 7:41 AM

Aug 29 2023

jon requested review of D9015: [shared/grpc_clients] Add verify_user_access_token().
Aug 29 2023, 6:56 PM
jon requested review of D9014: [Commtest] Remove backup gRPC tests.
Aug 29 2023, 2:00 PM

Aug 27 2023

jon closed D8917: [shared/grpc_clients] Export tonic to avoid version mismatch.
Aug 27 2023, 11:59 PM
jon closed D8916: [Identity] Improve VerifyUserAccessToken logging.
Aug 27 2023, 11:59 PM
jon committed rCOMMa97c8af031b2: [shared/grpc_clients] Export tonic to avoid version mismatch (authored by jon).
[shared/grpc_clients] Export tonic to avoid version mismatch
Aug 27 2023, 11:59 PM
jon closed D8891: [Identity] Adopt TLS-enabled tunnelbroker client.
Aug 27 2023, 11:59 PM
jon committed rCOMMd3c3ab934b90: [Identity] Improve VerifyUserAccessToken logging (authored by jon).
[Identity] Improve VerifyUserAccessToken logging
Aug 27 2023, 11:59 PM
jon committed rCOMM9563d223292e: [Identity] Adopt TLS-enabled tunnelbroker client (authored by jon).
[Identity] Adopt TLS-enabled tunnelbroker client
Aug 27 2023, 11:59 PM
jon closed D8890: [gRPC_Clients] Add tunnelbroker client.
Aug 27 2023, 11:59 PM
jon closed D8878: [Identity] Show consumed capacity when running query.
Aug 27 2023, 11:59 PM
jon committed rCOMM7aa7ce21abe9: [gRPC_Clients] Add tunnelbroker client (authored by jon).
[gRPC_Clients] Add tunnelbroker client
Aug 27 2023, 11:59 PM
jon committed rCOMMd5c0e5cf5ea7: [Identity] Show consumed capacity when running query (authored by jon).
[Identity] Show consumed capacity when running query
Aug 27 2023, 11:59 PM
jon closed D8817: [Treewide] Rename onetime to one_time.
Aug 27 2023, 11:59 PM
jon committed rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time (authored by jon).
[Treewide] Rename onetime to one_time
Aug 27 2023, 11:59 PM
jon added inline comments to D8890: [gRPC_Clients] Add tunnelbroker client.
Aug 27 2023, 10:45 PM
jon updated the diff for D8890: [gRPC_Clients] Add tunnelbroker client.

Make less specific than just identity service

Aug 27 2023, 10:44 PM
jon updated the diff for D8878: [Identity] Show consumed capacity when running query.

Use debug! for read capacity

Aug 27 2023, 10:42 PM
jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Fixed miss rename

Aug 27 2023, 10:25 PM
jon closed D8816: [Native] Encode platform type in native_rust_library.
Aug 27 2023, 7:51 PM
jon closed D8749: [Identity/Tunnelbroker] Add integration tests.
Aug 27 2023, 7:51 PM
jon committed rCOMM775d454deda1: [Identity/Tunnelbroker] Add integration tests (authored by jon).
[Identity/Tunnelbroker] Add integration tests
Aug 27 2023, 7:51 PM
jon committed rCOMMfd0097809bec: [Native] Encode platform type in native_rust_library (authored by jon).
[Native] Encode platform type in native_rust_library
Aug 27 2023, 7:51 PM

Aug 25 2023

jon requested review of D8918: [Tunnelbroker] Authenticate connecting devices.
Aug 25 2023, 5:20 PM
jon updated the diff for D8917: [shared/grpc_clients] Export tonic to avoid version mismatch.

Rebase on top of master

Aug 25 2023, 4:53 PM
jon updated the diff for D8916: [Identity] Improve VerifyUserAccessToken logging.

Rebase on top of master

Aug 25 2023, 4:53 PM
jon updated the diff for D8891: [Identity] Adopt TLS-enabled tunnelbroker client.

Rebase on top of master

Aug 25 2023, 4:53 PM
jon updated the diff for D8890: [gRPC_Clients] Add tunnelbroker client.

Rebase on top of master

Aug 25 2023, 4:53 PM
jon updated the diff for D8878: [Identity] Show consumed capacity when running query.

Rebase on top of master

Aug 25 2023, 4:53 PM
jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Rebase on top of master

Aug 25 2023, 4:52 PM
jon updated the diff for D8816: [Native] Encode platform type in native_rust_library.

Rebase on top of master

Aug 25 2023, 4:52 PM
jon updated the diff for D8749: [Identity/Tunnelbroker] Add integration tests.

Rebase on top of master

Aug 25 2023, 4:52 PM
jon accepted D8951: [reports-service] Add authenticated service.

Not sure about the specifics of authentication, but the rust looks fine.

Aug 25 2023, 4:48 PM
jon accepted D8947: [reports-service] Add HTTP server.
Aug 25 2023, 4:44 PM
jon accepted D8942: [reports-service] Introduce database client.
Aug 25 2023, 4:37 PM
jon accepted D8940: [report-service] Implement DB item size checks.
Aug 25 2023, 4:31 PM
jon accepted D8939: [report-service] Implement DB row item type.
Aug 25 2023, 4:28 PM
jon accepted D8938: [report-service] Add report types DB conversions.
Aug 25 2023, 4:15 PM
jon added a comment to D8937: [report-service] Add report types structs.

rust LGTM, not familiar with reports though, so I would like a second opinion

Aug 25 2023, 4:15 PM
jon requested review of D8957: [Keyserver] Use getCommConfig for tunnelbroker connection.
Aug 25 2023, 3:58 PM
jon requested review of D8956: [Keyserver] Validate incoming tunnelbroker messages.
Aug 25 2023, 3:54 PM
jon added inline comments to D8895: [services-lib] Add BatchWriteItem utility function.
Aug 25 2023, 1:05 PM
jon accepted D8883: [backup] Use blob client.
Aug 25 2023, 8:25 AM

Aug 23 2023

jon updated the diff for D8917: [shared/grpc_clients] Export tonic to avoid version mismatch.

Fix docker build

Aug 23 2023, 12:48 PM
jon added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Aug 23 2023, 10:29 AM
jon updated the diff for D8817: [Treewide] Rename onetime to one_time.

Rebase after conflict changes in previous diff

Aug 23 2023, 10:27 AM
jon added a comment to D8816: [Native] Encode platform type in native_rust_library.

We don't need native as an option here.
To deliberately avoid ambiguity, I explicitly enumerated the full list of device types you should support in two places: Phabricator and Comm ("How to differentiate between different Comm devices" thread under "Services team" channel).
It's already frustrating to me that I have to micromanage to this degree. Ideally I should not have to give you explicit guidance at all, but the fact that guidance is frequently ignored means that I need to review every single one of your diffs.
This is the same problem as in D7691. There is very little that frustrates me more than feeling like the effort I put into careful, thoughtful, explicit communication is wasted and ignored.

Aug 23 2023, 10:24 AM
jon updated the diff for D8816: [Native] Encode platform type in native_rust_library.
  • Remove Native
  • iOS -> Ios
Aug 23 2023, 10:24 AM
jon updated the diff for D8891: [Identity] Adopt TLS-enabled tunnelbroker client.

Add missed changes

Aug 23 2023, 9:31 AM
jon accepted D8863: [identity] getInboundKeysForUser RPC implementation.
Aug 23 2023, 9:03 AM
jon added inline comments to D8911: [services-lib] Add authorization http middleware.
Aug 23 2023, 8:47 AM
jon added inline comments to D8895: [services-lib] Add BatchWriteItem utility function.
Aug 23 2023, 8:32 AM

Aug 22 2023

jon requested review of D8917: [shared/grpc_clients] Export tonic to avoid version mismatch.
Aug 22 2023, 11:00 AM
jon requested review of D8916: [Identity] Improve VerifyUserAccessToken logging.
Aug 22 2023, 10:59 AM

Aug 21 2023

jon requested changes to D8883: [backup] Use blob client.
Aug 21 2023, 7:43 PM
jon added inline comments to D8882: [backup] Basic http server.
Aug 21 2023, 12:32 PM
jon accepted D8881: [services] Extract cors config to services-lib.
Aug 21 2023, 12:26 PM
jon requested review of D8891: [Identity] Adopt TLS-enabled tunnelbroker client.
Aug 21 2023, 7:17 AM
jon requested review of D8890: [gRPC_Clients] Add tunnelbroker client.
Aug 21 2023, 7:16 AM
jon added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Aug 21 2023, 12:15 AM
jon updated the diff for D8752: [Keyserver] Upload new onetime keys to identity service when requested.

Address feedback

Aug 21 2023, 12:14 AM
jon updated the diff for D8749: [Identity/Tunnelbroker] Add integration tests.

Use ConnectionInitializationMessage as message name

Aug 21 2023, 12:06 AM

Aug 20 2023

jon requested review of D8878: [Identity] Show consumed capacity when running query.
Aug 20 2023, 11:51 PM
jon closed D8748: [Identity] Issue refresh_key_request to tunnelbroker.
Aug 20 2023, 11:49 PM
jon committed rCOMM3727b2debecb: [Identity] Issue refresh_key_request to tunnelbroker (authored by jon).
[Identity] Issue refresh_key_request to tunnelbroker
Aug 20 2023, 11:49 PM
jon closed D8475: [Keyserver] Refactor identity utilities.
Aug 20 2023, 11:47 PM
jon committed rCOMM4b40142ee014: [Keyserver] Refactor identity utilities (authored by jon).
[Keyserver] Refactor identity utilities
Aug 20 2023, 11:47 PM
jon closed D8723: [Identity] Allow for tunnelbroker endpoint to be configured.
Aug 20 2023, 11:40 PM
jon committed rCOMMcc457d50583f: [Identity] Allow for tunnelbroker endpoint to be configured (authored by jon).
[Identity] Allow for tunnelbroker endpoint to be configured
Aug 20 2023, 11:40 PM
jon abandoned D8722: [Identity] Implement GetKeyserverKeys.

When trying to patch this in, it got added to the previous diff. Will add @bartek suggestion to later diff

Aug 20 2023, 11:23 PM
jon closed D8721: [Identity] Add some utilties with manipulating DDB results.
Aug 20 2023, 10:24 PM
jon committed rCOMMc107c9ad68bc: [Identity] Add some utilties with manipulating DDB results (authored by jon).
[Identity] Add some utilties with manipulating DDB results
Aug 20 2023, 10:24 PM
jon closed D8675: [Identity] Add DDB table for one-time-keys.
Aug 20 2023, 10:24 PM
jon committed rCOMMbdabed9dccb1: [Identity] Add DDB table for one-time-keys (authored by jon).
[Identity] Add DDB table for one-time-keys
Aug 20 2023, 10:24 PM
jon updated the diff for D8675: [Identity] Add DDB table for one-time-keys.

Emphasize PARTITION_KEY in comment

Aug 20 2023, 9:55 PM
jon updated the diff for D8752: [Keyserver] Upload new onetime keys to identity service when requested.

Address feedback. Correct async/await usage

Aug 20 2023, 9:34 PM

Aug 18 2023

jon accepted D8765: [identity] more helpers for identity service.
Aug 18 2023, 1:32 PM
jon accepted D8761: [identity] db method to get inbound keys for user.
Aug 18 2023, 1:31 PM
jon accepted D8865: [reports-service] Add basic config.
Aug 18 2023, 1:06 PM