[report-service] Add report types structs
ClosedPublic
Actions

Authored by bartek on Aug 25 2023, 8:07 AM.

Details

Reviewers

michal
• patryk
varun
• jon

Commits

rCOMMb2bcf2b1d29b: [report-service] Add report types structs

Summary

Introduce structs for report types, to be used in the report service.
They're somehow counterparts of lib/types/report_types.js but modified to be properly serialized/deserialized by Serde.

Depends on D8865

Test Plan

Tested together with further diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 25 2023, 8:07 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 25 2023, 8:07 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8938: [report-service] Add report types DB conversions.Aug 25 2023, 8:10 AM

Harbormaster completed remote builds in B22073: Diff 30298.Aug 25 2023, 8:24 AM

bartek published this revision for review.Aug 25 2023, 8:47 AM

rust LGTM, not familiar with reports though, so I would like a second opinion

Not a fan of ReportInput::time handling with serde, but I don't think we can do much better...

services/reports/src/report_types.rs
12 ↗	(On Diff #30298)	NIT: `repr(transparent)` suggests we depend on it's layout somewhere
59–60 ↗	(On Diff #30298)	We might want to move to `string` to handle semver in the future ENG-3908