Page MenuHomePhabricator

[reports-service] Implement Blob storage
ClosedPublic

Authored by bartek on Aug 28 2023, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 11:57 AM
Unknown Object (File)
Fri, Nov 8, 6:20 PM
Unknown Object (File)
Mon, Nov 4, 4:57 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Subscribers

Details

Summary

Implemented storing large reports in blob service and retrieving them.

Depends on D8974, D8940

Test Plan

The plan requires D8971 to easily upload and view reports

  1. Commented out the size check to store all reports in blob service.
  2. Uploaded multiple reports. Verified that they are stored in blob service.
  3. Downloaded one report directly from blob service, using blob hash. When opened the file, it contained the report JSON.
  4. Viewed the report using report HTTP endpoint

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Aug 28 2023, 4:24 AM

Adding @tomek because of new dependency while @ashoat is unavailable

But also sha2, seems much more popular than sha256. We use in commtest already

Adding @tomek because of new dependency while @ashoat is unavailable

But also sha2, seems much more popular than sha256. We use in commtest already

agreed we should use sha2 if possible

Use sha2 instead of sha256 for hashing

I'm not necessarily happy because in fact I had to add the hex too, previous library was more convenient :P Anyway, it works

The dependency looks ok

This revision is now accepted and ready to land.Aug 30 2023, 2:10 AM
This revision was automatically updated to reflect the committed changes.