We're going to store ReportItems in DynamoDB. The maximum item size is 400 KiB. We need to ensure that the items we're storing are not larger than that.
In further diffs, such large reports will be stored in Blob service.
Depends on D8939
Details
Details
- Created a ReportItem with very long generated string content. Repeatedly increased length.
- Printed value of total_size() and inserted the row to DDB.
- Verified that for values slightly larger than 409600 (400 KiB) insertion failed with ItemTooLargeException.
- When called ensure_size_constraints() for failing items, the todo!() was hit.
- When called for smaller, non-failing items, the function returned early.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/reports/src/database/item.rs | ||
|---|---|---|
| 97–102 ↗ | (On Diff #30301) | although this has the desired behavior, it does feel a little odd at a glance. Maybe use a different name for the inner size calculation? |
| services/reports/src/database/item.rs | ||
|---|---|---|
| 97–102 ↗ | (On Diff #30301) | Yep, shadowing is usually an antipattern. I'll change this |