Paths

Table of Contentst

Differential D9035

[reports-service] Encrypt reports
ClosedPublic
Actions

Authored by bartek on Aug 30 2023, 1:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 27, 3:48 PM

	Unknown Object (File)
	Sun, Oct 27, 3:48 PM

	Unknown Object (File)
	Sun, Oct 27, 3:48 PM

	Unknown Object (File)
	Sun, Oct 27, 3:48 PM

	Unknown Object (File)
	Sun, Oct 27, 3:42 PM

	Unknown Object (File)
	Oct 15 2024, 11:49 PM

	Unknown Object (File)
	Oct 15 2024, 11:44 PM

	Unknown Object (File)
	Oct 12 2024, 12:32 PM

View All 86 Files

Subscribers

Details

Reviewers

michal
varun
• patryk
• jon

Commits

rCOMM0bb3cda63aab: [reports-service] Encrypt reports

Summary

ENG-4812.
Added encryption/decryption step for reports. It can be disabled via CLI flag (useful for debugging/local dev).

Depends on D9034, D8988

Test Plan

Stored a report in the database, then retrieved it via the API. Verified that the report was encrypted in the database and decrypted when retrieved.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 30 2023, 1:52 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 30 2023, 1:52 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B22282: Diff 30607.Aug 30 2023, 2:18 PM

bartek published this revision for review.Aug 30 2023, 2:27 PM

bartek added inline comments.

services/reports/src/http/mod.rs
89 ↗	(On Diff #30607)	This pattern is no longer unreachable - the `EncryptionError` now matches it
services/reports/src/service.rs
43–45 ↗	(On Diff #30607)	This is a zero-sized error - the AES library error is also 0-sized and doesn't provide any meaningful message

michal accepted this revision.Aug 31 2023, 1:50 AM

michal added inline comments.

services/reports/src/service.rs
44 ↗	(On Diff #30607)	Is it possible to do something like this (probably with re-exported error from comm-services-lib)?

This revision is now accepted and ready to land.Aug 31 2023, 1:50 AM

Rebase

bartek added inline comments.Sep 9 2023, 2:24 AM

services/reports/src/service.rs
44 ↗	(On Diff #30607)	not really, derive_more is indeed limited

Harbormaster completed remote builds in B22467: Diff 30888.Sep 9 2023, 2:27 AM

Closed by commit rCOMM0bb3cda63aab: [reports-service] Encrypt reports (authored by bartek). · Explain WhySep 9 2023, 11:00 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0bb3cda63aab: [reports-service] Encrypt reports.

Revision Contents
Changeset List

Path

Size

services/

reports/

1 line

src/

13 lines

database/

9 lines

http/

1 line

53 lines

Diff 30899

services/reports/Cargo.lock

Loading...

services/reports/Cargo.toml

Loading...

services/reports/src/config.rs

Loading...

services/reports/src/database/item.rs

Loading...

services/reports/src/http/mod.rs

Loading...

services/reports/src/service.rs

Loading...