[reports-service] E-mail: inconsistency report details
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 11:04 PM.

Details

Reviewers

michal
• patryk
• jon

Commits

rCOMMd30c4df4513f: [reports-service] E-mail: inconsistency report details

Summary

Commbot messages for inconsistency reports have additional note about inconsistent fields. This diff reproduces this for report service emails.

Depends on D8985

Test Plan

Created a temporary HTTP endpoint that renders this HTML and opened it in the browser.
Screenshots of the final result in D8988

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 28 2023, 11:04 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 11:04 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8987: [reports-service] Add functions to send e-mails.Aug 28 2023, 11:05 PM

bartek retitled this revision from [reports-service] Add inconsistency report utils to [reports-service] E-mail: inconsistency report details.Aug 28 2023, 11:08 PM

Harbormaster completed remote builds in B22187: Diff 30463.Aug 28 2023, 11:21 PM

bartek edited the summary of this revision. (Show Details)Aug 29 2023, 12:04 AM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Aug 29 2023, 12:22 AM

bartek added inline comments.

services/reports/src/report_utils.rs
7 ↗	(On Diff #30463)	This is a counterpart of this function
48 ↗	(On Diff #30463)	This is not implemented because I'd need to rewrite in Rust most of this file: https://github.com/CommE2E/comm/blob/a97c8af031b233112af53b1159e01aa602e4376a/lib/shared/entry-utils.js I'll probably create a follow-up task