[reports-service] Add functions to send e-mails
ClosedPublic
Actions

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

This revision now requires changes to proceed.Aug 30 2023, 2:37 AM

In D8987#265730, @tomek wrote:

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

There's no official Rust library for Postmark. The service itself offers a REST API over which this library is a thin wrapper. We found it during 1:1 with @ashoat, I quickly looked at its source code and it looks alright. If you feel strongly, I can implement the API calls directly as a follow-up task, but this will introduce more maintenance overhead.
Quickly looked for other alternatives, but these libraries are poor or not maintained at all.

In D8987#265759, @bartek wrote:

In D8987#265730, @tomek wrote:

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

There's no official Rust library for Postmark. The service itself offers a REST API over which this library is a thin wrapper. We found it during 1:1 with @ashoat, I quickly looked at its source code and it looks alright. If you feel strongly, I can implement the API calls directly as a follow-up task, but this will introduce more maintenance overhead.
Quickly looked for other alternatives, but these libraries are poor or not maintained at all.

Ok, that makes sense - I guess we can keep this library.

This revision is now accepted and ready to land.Aug 30 2023, 4:20 AM

Closed by commit rCOMMa6aa509088ec: [reports-service] Add functions to send e-mails (authored by bartek). · Explain WhySep 3 2023, 11:41 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa6aa509088ec: [reports-service] Add functions to send e-mails.

Revision Contents
Changeset List

Path

Size

services/

reports/

Cargo.lock

Cargo.toml

1 line

src/

email/

config.rs

12 lines

mod.rs

71 lines

Diff 30726

View Options

services/reports/Cargo.lock

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines	if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are		// if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by		// erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker.		// DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID);		DeliveryBroker::getInstance().erase(clientDeviceID);
}		}
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
auto respondToWriter =		auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) {		[&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID);		response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload);		response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
response.Clear();		response.Clear();
};		};
for (auto &messageFromDatabase : messagesFromDatabase) {		for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter(		respondToWriter(
Show All 28 Lines

View Options

services/reports/Cargo.toml

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines	if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are		// if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by		// erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker.		// DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID);		DeliveryBroker::getInstance().erase(clientDeviceID);
}		}
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
auto respondToWriter =		auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) {		[&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID);		response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload);		response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
response.Clear();		response.Clear();
};		};
for (auto &messageFromDatabase : messagesFromDatabase) {		for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter(		respondToWriter(
Show All 28 Lines

View Options

services/reports/src/email/config.rs

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines	if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are		// if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by		// erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker.		// DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID);		DeliveryBroker::getInstance().erase(clientDeviceID);
}		}
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
auto respondToWriter =		auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) {		[&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID);		response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload);		response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
response.Clear();		response.Clear();
};		};
for (auto &messageFromDatabase : messagesFromDatabase) {		for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter(		respondToWriter(
Show All 28 Lines

View Options

services/reports/src/email/mod.rs

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines	if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are		// if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by		// erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker.		// DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID);		DeliveryBroker::getInstance().erase(clientDeviceID);
}		}
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
auto respondToWriter =		auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) {		[&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID);		response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload);		response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
response.Clear();		response.Clear();
};		};
for (auto &messageFromDatabase : messagesFromDatabase) {		for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter(		respondToWriter(
Show All 28 Lines

[reports-service] Add functions to send e-mailsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30726

services/reports/Cargo.lock

services/reports/Cargo.toml

services/reports/src/email/config.rs

services/reports/src/email/mod.rs

[reports-service] Add functions to send e-mails
ClosedPublic
Actions

Revision Contents
Changeset List