Page MenuHomePhabricator

[reports-service] Add functions to send e-mails
ClosedPublic

Authored by bartek on Aug 28 2023, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Sep 27 2024, 9:48 PM
Unknown Object (File)
Sep 18 2024, 4:48 AM
Unknown Object (File)
Sep 11 2024, 5:14 PM
Unknown Object (File)
Sep 11 2024, 5:14 PM
Subscribers

Details

Summary

This diff adds a Postmark client and two functions: One to compose an e-mail object and another to send all the emails in batch

Depends on D8986

Test Plan

Test plan in child diff D898 where these functions are called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Aug 29 2023, 12:22 AM
michal added a reviewer: tomek.

Adding @tomek because of a new dependency

This revision is now accepted and ready to land.Aug 29 2023, 9:49 AM
This revision now requires review to proceed.Aug 30 2023, 1:54 AM
tomek requested changes to this revision.Aug 30 2023, 2:37 AM

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

This revision now requires changes to proceed.Aug 30 2023, 2:37 AM
In D8987#265730, @tomek wrote:

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

There's no official Rust library for Postmark. The service itself offers a REST API over which this library is a thin wrapper. We found it during 1:1 with @ashoat, I quickly looked at its source code and it looks alright. If you feel strongly, I can implement the API calls directly as a follow-up task, but this will introduce more maintenance overhead.
Quickly looked for other alternatives, but these libraries are poor or not maintained at all.

In D8987#265730, @tomek wrote:

The license is ok, but the library doesn't have too many downloads and the repo has only 6 stars. It also isn't mentioned by Postmark as official https://postmarkapp.com/developer/integration/official-libraries or community https://postmarkapp.com/developer/integration/community-libraries library. Are there any alternatives? Have we considered sending HTTP requests directly?

There's no official Rust library for Postmark. The service itself offers a REST API over which this library is a thin wrapper. We found it during 1:1 with @ashoat, I quickly looked at its source code and it looks alright. If you feel strongly, I can implement the API calls directly as a follow-up task, but this will introduce more maintenance overhead.
Quickly looked for other alternatives, but these libraries are poor or not maintained at all.

Ok, that makes sense - I guess we can keep this library.

This revision is now accepted and ready to land.Aug 30 2023, 4:20 AM