Page MenuHomePhabricator
Differential D8892

[services] Extract multipart handling logic to lib
ClosedPublic
Actions

Authored by michal on Aug 21 2023, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 3:51 AM
Unknown Object (File)
Tue, Mar 25, 7:17 AM
Unknown Object (File)
Tue, Mar 25, 7:16 AM
Unknown Object (File)
Tue, Mar 25, 7:16 AM
Unknown Object (File)
Tue, Mar 25, 7:16 AM
Unknown Object (File)
Tue, Mar 25, 7:16 AM
Unknown Object (File)
Tue, Mar 25, 7:16 AM
Unknown Object (File)
Sat, Mar 22, 8:50 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
• patryk
kamil
• jon
Commits
rCOMMdae730244c05: [services] Extract multipart handling logic to lib
Summary

A few things related to multipart parsing will be useful to the backup service:

  • general function for handling text fields
  • ByteStream alias (changed to use Byte instead of Vec<u8> to avoid unnecessary allocations)
  • Also removed a few unnecessary map_err(Box::new) and fixed typos

Depends on D8889

Test Plan

yarn run-integration-tests blob

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Aug 21 2023, 10:34 AM
Herald added a reviewer: • jon. · View Herald TranscriptAug 21 2023, 10:34 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B21960: Diff 30157.Aug 21 2023, 10:51 AM
michal requested review of this revision.Aug 21 2023, 10:51 AM
bartek accepted this revision.Aug 22 2023, 12:12 AM
This revision is now accepted and ready to land.Aug 22 2023, 12:12 AM
michal added a child revision: D8911: [services-lib] Add authorization http middleware.Aug 22 2023, 6:46 AM
michal updated this revision to Diff 30314.Aug 25 2023, 6:00 AM

Rebase

Harbormaster failed remote builds in B22086: Diff 30314!Aug 25 2023, 6:04 AM
michal updated this revision to Diff 30316.Aug 25 2023, 6:20 AM

Regenerate backup lockfile because of issues with resolving deps. Also updated lockfile of feature flags from anyhow in lib.

Harbormaster completed remote builds in B22088: Diff 30316.Aug 25 2023, 6:38 AM
Closed by commit rCOMMdae730244c05: [services] Extract multipart handling logic to lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 25 2023, 9:40 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMdae730244c05: [services] Extract multipart handling logic to lib.

Revision Contents
Changeset List

PathSize
services/
backup/
blob/
src/
http/
handlers/
54 lines
8 lines
14 lines
comm-services-lib/
15 lines
src/
15 lines
http/
42 lines
2 lines
feature-flags/

Diff 30326

View Options

services/backup/Cargo.lock

Loading...
View Options

services/blob/Cargo.lock

Loading...
View Options

services/blob/src/http/handlers/blob.rs

Loading...
View Options

services/blob/src/service.rs

Loading...
View Options

services/blob/src/tools.rs

Loading...
View Options

services/comm-services-lib/Cargo.lock

Loading...
View Options

services/comm-services-lib/Cargo.toml

Loading...
View Options

services/comm-services-lib/src/http.rs

Loading...
View Options

services/comm-services-lib/src/http/multipart.rs

Loading...
View Options

services/comm-services-lib/src/tools.rs

Loading...
View Options

services/feature-flags/Cargo.lock

Loading...