Paths

Table of Contentst

[services] Extract multipart handling logic to lib
ClosedPublic
Actions

Authored by michal on Aug 21 2023, 10:34 AM.

Details

Reviewers

bartek
• patryk
kamil
• jon

Commits

rCOMMdae730244c05: [services] Extract multipart handling logic to lib

Summary

A few things related to multipart parsing will be useful to the backup service:

general function for handling text fields
ByteStream alias (changed to use Byte instead of Vec<u8> to avoid unnecessary allocations)
Also removed a few unnecessary map_err(Box::new) and fixed typos

Depends on D8889

Test Plan

yarn run-integration-tests blob

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 21 2023, 10:34 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 21 2023, 10:34 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B21960: Diff 30157.Aug 21 2023, 10:51 AM

michal requested review of this revision.Aug 21 2023, 10:51 AM

bartek accepted this revision.Aug 22 2023, 12:12 AM

This revision is now accepted and ready to land.Aug 22 2023, 12:12 AM

michal added a child revision: D8911: [services-lib] Add authorization http middleware.Aug 22 2023, 6:46 AM

Rebase

Harbormaster failed remote builds in B22086: Diff 30314!Aug 25 2023, 6:04 AM

Regenerate backup lockfile because of issues with resolving deps. Also updated lockfile of feature flags from anyhow in lib.

Harbormaster completed remote builds in B22088: Diff 30316.Aug 25 2023, 6:38 AM

Closed by commit rCOMMdae730244c05: [services] Extract multipart handling logic to lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 25 2023, 9:40 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMdae730244c05: [services] Extract multipart handling logic to lib.

Revision Contents
Changeset List

Path

Size

services/

backup/

Cargo.lock

blob/

Cargo.lock

src/

http/

handlers/

blob.rs

54 lines

service.rs

8 lines

tools.rs

14 lines

comm-services-lib/

Cargo.lock

Cargo.toml

15 lines

src/

http.rs

15 lines

http/

multipart.rs

42 lines

tools.rs

2 lines

feature-flags/

Cargo.lock

Diff 30326

View Options

services/backup/Cargo.lock

View Options

services/blob/Cargo.lock

View Options

services/blob/src/http/handlers/blob.rs

View Options

services/blob/src/service.rs

View Options

services/blob/src/tools.rs

View Options

services/comm-services-lib/Cargo.lock

View Options

services/comm-services-lib/Cargo.toml

View Options

services/comm-services-lib/src/http.rs

View Options

services/comm-services-lib/src/http/multipart.rs

View Options

services/comm-services-lib/src/tools.rs

View Options

services/feature-flags/Cargo.lock

[services] Extract multipart handling logic to libClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30326

services/backup/Cargo.lock

services/blob/Cargo.lock

services/blob/src/http/handlers/blob.rs

services/blob/src/service.rs

services/blob/src/tools.rs

services/comm-services-lib/Cargo.lock

services/comm-services-lib/Cargo.toml

services/comm-services-lib/src/http.rs

services/comm-services-lib/src/http/multipart.rs

services/comm-services-lib/src/tools.rs

services/feature-flags/Cargo.lock

[services] Extract multipart handling logic to lib
ClosedPublic
Actions

Revision Contents
Changeset List