Page MenuHomePhabricator

[services] Extract cors config to services-lib
ClosedPublic

Authored by michal on Aug 21 2023, 2:07 AM.
Tags
None
Referenced Files
F5894484: D8881.id30127.diff
Thu, Apr 17, 10:27 AM
F5893409: D8881.id30153.diff
Thu, Apr 17, 9:13 AM
F5887200: D8881.id30200.diff
Thu, Apr 17, 4:27 AM
Unknown Object (File)
Thu, Apr 17, 12:20 AM
Unknown Object (File)
Wed, Apr 16, 8:27 AM
Unknown Object (File)
Tue, Apr 8, 4:33 PM
Unknown Object (File)
Wed, Mar 19, 5:58 AM
Unknown Object (File)
Mar 16 2025, 11:04 PM
Subscribers

Details

Summary

ENG-4501
Backup service will be now a http servce so it will need a cors config. This diff extracts it from blob to services lib.

Depends on D8869

Test Plan

cargo build in blob

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

services/blob/Cargo.toml
26–32 ↗(On Diff #30127)

VSCode automatically formatted these lines. They are a bit more consistent now so I included it in this diff

services/comm-services-lib/src/lib.rs
4–5 ↗(On Diff #30127)

Added a new module/ feature for http related things

jon added inline comments.
services/comm-services-lib/src/lib.rs
3–4 ↗(On Diff #30153)

Nice, like the feature-opt-in aspect of this.

This revision is now accepted and ready to land.Aug 21 2023, 12:26 PM