Paths

Table of Contentst

Differential D8881

[services] Extract cors config to services-lib
ClosedPublic
Actions

Authored by michal on Aug 21 2023, 2:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 5:57 PM

	Unknown Object (File)
	Thu, Apr 4, 1:40 PM

	Unknown Object (File)
	Thu, Apr 4, 1:40 PM

	Unknown Object (File)
	Thu, Apr 4, 1:40 PM

	Unknown Object (File)
	Thu, Apr 4, 1:39 PM

	Unknown Object (File)
	Thu, Apr 4, 1:28 PM

	Unknown Object (File)
	Mar 5 2024, 6:05 AM

	Unknown Object (File)
	Mar 5 2024, 6:05 AM

View All 26 Files

Subscribers

Details

Reviewers

bartek
kamil
• patryk
• jon

Commits

rCOMM6fcda8c904f5: [services] Extract cors config to services-lib

Summary

ENG-4501
Backup service will be now a http servce so it will need a cors config. This diff extracts it from blob to services lib.

Depends on D8869

Test Plan

cargo build in blob

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 21 2023, 2:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 21 2023, 2:07 AM

michal added inline comments.Aug 21 2023, 2:10 AM

services/blob/Cargo.toml
26–32 ↗	(On Diff #30127)	VSCode automatically formatted these lines. They are a bit more consistent now so I included it in this diff
services/comm-services-lib/src/lib.rs
4–5 ↗	(On Diff #30127)	Added a new module/ feature for http related things

michal added a child revision: D8882: [backup] Basic http server.Aug 21 2023, 2:13 AM

Harbormaster completed remote builds in B21935: Diff 30127.Aug 21 2023, 2:25 AM

michal requested review of this revision.Aug 21 2023, 2:25 AM

Rebase

Harbormaster completed remote builds in B21956: Diff 30153.Aug 21 2023, 9:59 AM

• jon accepted this revision.Aug 21 2023, 12:26 PM

• jon added inline comments.

services/comm-services-lib/src/lib.rs
3–4 ↗	(On Diff #30153)	Nice, like the feature-opt-in aspect of this.

This revision is now accepted and ready to land.Aug 21 2023, 12:26 PM

bartek accepted this revision.Aug 22 2023, 12:14 AM

Closed by commit rCOMM6fcda8c904f5: [services] Extract cors config to services-lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 22 2023, 3:21 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM6fcda8c904f5: [services] Extract cors config to services-lib.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob/

9 lines

src/

http/

22 lines

comm-services-lib/

3 lines

src/

18 lines

2 lines

Diff 30200

services/backup/Cargo.lock

Loading...

services/blob/Cargo.lock

Loading...

services/blob/Cargo.toml

Loading...

services/blob/src/http/mod.rs

Loading...

services/comm-services-lib/Cargo.lock

Loading...

services/comm-services-lib/Cargo.toml

Loading...

services/comm-services-lib/src/http.rs

Loading...

services/comm-services-lib/src/lib.rs

Loading...