Page MenuHomePhabricator

michal (Michał Gniadek)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2022, 2:37 AM (89 w, 3 d)

Recent Activity

Apr 5 2024

michal accepted D11565: [lib] Simplify sorting local ids.
Apr 5 2024, 7:23 AM
michal accepted D11564: [lib] Fix sorting local messages.
Apr 5 2024, 6:43 AM
michal updated the test plan for D11538: [web] Persist userStore in db.
Apr 5 2024, 6:35 AM
michal updated the diff for D11539: [web] Persist messageStore in db.

Fixes

Apr 5 2024, 6:17 AM
michal updated the diff for D11544: [web] Clear database on non-threadStore ops fail.

Use entries instead of specifying each ops separately.

Apr 5 2024, 5:45 AM
michal updated the diff for D11545: [web/native/lib] Use message pruner on web.

Merge imports

Apr 5 2024, 5:42 AM
michal updated the diff for D11538: [web] Persist userStore in db.

Fix path, spread type instead of repeating.

Apr 5 2024, 5:30 AM
michal updated the diff for D11539: [web] Persist messageStore in db.

D11552 was landed so removed the change that persisted the nextLocalID as it's now a random uuid and there won't be conflicts after app reload.

Apr 5 2024, 3:50 AM
michal updated the diff for D11538: [web] Persist userStore in db.

Rebase

Apr 5 2024, 3:48 AM
michal updated the diff for D11539: [web] Persist messageStore in db.

Like in previous diff, realized that user infos are used by navinfo in redux state responder so separated the new promise.

Apr 5 2024, 3:43 AM
michal updated the diff for D11538: [web] Persist userStore in db.

Realized that user infos are used by navinfo in redux state responder so separated the new promise.

Apr 5 2024, 3:40 AM
michal requested review of D11563: [web] Fix user not getting logged out on ops failure.
Apr 5 2024, 3:14 AM
michal updated the diff for D11537: [native] Move MessageStoreTransform to lib.

Add new line

Apr 5 2024, 3:04 AM
michal updated the diff for D11544: [web] Clear database on non-threadStore ops fail.

Rebase

Apr 5 2024, 3:02 AM
michal updated the diff for D11539: [web] Persist messageStore in db.

Rebase

Apr 5 2024, 3:01 AM
michal updated the diff for D11538: [web] Persist userStore in db.

Rebase

Apr 5 2024, 3:01 AM
michal updated the diff for D11535: [lib] Use userStore ops in reducer.

Rebase

Apr 5 2024, 3:00 AM

Apr 4 2024

michal accepted D11553: [lib][web][native] Remove nextLocalID from redux.
Apr 4 2024, 8:07 AM
michal accepted D11552: [lib][web][native] Use uuid for next local id.
Apr 4 2024, 7:58 AM

Apr 3 2024

michal requested review of D11545: [web/native/lib] Use message pruner on web.
Apr 3 2024, 7:55 AM
michal requested review of D11544: [web] Clear database on non-threadStore ops fail.
Apr 3 2024, 7:44 AM
michal updated the diff for D11539: [web] Persist messageStore in db.

Noticed an issue where the message sometimes wouldn't send. It turns out that's because we don't persist nextLocalID on web. So after reloading the webapp new messages had local ids starting from 0, and mesasge reducer started ignoring them.

Apr 3 2024, 6:52 AM
michal requested review of D11539: [web] Persist messageStore in db.
Apr 3 2024, 6:40 AM
michal requested review of D11538: [web] Persist userStore in db.
Apr 3 2024, 6:29 AM
michal requested review of D11535: [lib] Use userStore ops in reducer.
Apr 3 2024, 6:28 AM
michal requested review of D11537: [native] Move MessageStoreTransform to lib.
Apr 3 2024, 6:22 AM
michal requested review of D11536: [web] Update type field in DB Media struct.
Apr 3 2024, 6:19 AM
michal added inline comments to D11482: [web/native] Migrate keyserverStore to new tables.
Apr 3 2024, 4:02 AM
michal updated the diff for D11482: [web/native] Migrate keyserverStore to new tables.

Improve indentation

Apr 3 2024, 4:02 AM
michal updated the diff for D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.

Small fixes

Apr 3 2024, 4:02 AM
michal updated the diff for D11473: [sqlite] Add keyservers_synced_data table.

Rename table

Apr 3 2024, 4:00 AM
michal added inline comments to D11472: [native] Blocklist for backed up tables.
Apr 3 2024, 3:59 AM
michal updated the diff for D11472: [native] Blocklist for backed up tables.

Move function, rename, use SQLiteStatementWrapper

Apr 3 2024, 3:59 AM
michal accepted D11531: Reorder project.pbxproj after yarn cleaninstall.
Apr 3 2024, 2:45 AM

Apr 2 2024

michal accepted D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Apr 2 2024, 2:32 AM
michal requested changes to D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Apr 2 2024, 2:31 AM
michal accepted D11448: [native] update `decrypt` method use `EncryptedData`.
Apr 2 2024, 2:31 AM
michal accepted D11446: [native] update `encrypt` method to return `EncryptedData`.
Apr 2 2024, 2:26 AM

Mar 29 2024

michal requested review of D11482: [web/native] Migrate keyserverStore to new tables.
Mar 29 2024, 2:02 PM
michal requested review of D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.
Mar 29 2024, 1:58 PM
michal requested review of D11473: [sqlite] Add keyservers_synced_data table.
Mar 29 2024, 1:52 PM
michal requested review of D11472: [native] Blocklist for backed up tables.
Mar 29 2024, 7:03 AM
michal accepted D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Mar 29 2024, 6:40 AM
michal accepted D11447: [web] update `decrypt` method use `EncryptedData`.
Mar 29 2024, 6:29 AM
michal accepted D11445: [web] update `encrypt` method to return `EncryptedData`.
Mar 29 2024, 6:27 AM
michal accepted D11437: [lib] Wipe keyserver store on login.
Mar 29 2024, 4:08 AM

Mar 28 2024

michal accepted D11394: [lib][web][native] Handle idnentity login in reducers.
Mar 28 2024, 7:21 AM

Mar 27 2024

michal updated the diff for D11373: [web] Use shared worker crypto store in identity client provider.

Fixes

Mar 27 2024, 4:14 AM
michal updated the diff for D11372: [web/native] Create tunnelbroker init message on connection.

Made sure that tunnelbroker creation promises run sequentially so the order won't get messed up.

Mar 27 2024, 4:13 AM
michal added inline comments to D11386: [web/native] Add signMessage to olmAPI.
Mar 27 2024, 2:09 AM

Mar 26 2024

michal requested review of D11386: [web/native] Add signMessage to olmAPI.
Mar 26 2024, 7:16 AM
michal requested review of D11385: [web] Pass platform details to worker.
Mar 26 2024, 7:16 AM
michal updated the diff for D11352: [web] Deprecate non-worker opaque wasm.

Call opaque as soon as identity client is initialized (this is the first place where we have access to the opaque path on the worker).

Mar 26 2024, 7:04 AM
michal updated the diff for D11348: [web] Use crypto store and olm from shared worker.

Rebase on changes to the web qr login screen.

Mar 26 2024, 7:03 AM
michal updated the diff for D11342: [web/native] Move notificationsSessionCreator to olmAPI.

Rebase on changes to the notification session creator.

Mar 26 2024, 6:59 AM
michal updated the diff for D11326: [web] Persist web sessions.

Rebase

Mar 26 2024, 6:54 AM

Mar 22 2024

michal accepted D11363: [web] don't generate or send one time keys on login.
Mar 22 2024, 9:15 AM
michal requested review of D11373: [web] Use shared worker crypto store in identity client provider.
Mar 22 2024, 9:14 AM
michal requested review of D11372: [web/native] Create tunnelbroker init message on connection.
Mar 22 2024, 9:11 AM
michal updated the diff for D11348: [web] Use crypto store and olm from shared worker.

Moved the identity client provider and tunnelbroker changes to D11373 and D11372 because they were more complicated after fixes.

Mar 22 2024, 9:02 AM

Mar 20 2024

michal added inline comments to D11352: [web] Deprecate non-worker opaque wasm.
Mar 20 2024, 4:27 AM
michal planned changes to D11348: [web] Use crypto store and olm from shared worker.

You are correct this doesn't actually work as I had hoped.

Mar 20 2024, 4:26 AM

Mar 19 2024

michal requested review of D11355: [backup] Revoke holders of replaced log items.
Mar 19 2024, 10:48 AM
michal updated the diff for D11352: [web] Deprecate non-worker opaque wasm.

Move file

Mar 19 2024, 9:36 AM
michal added inline comments to D11351: [web] Migrate crypto store to shared worker.
Mar 19 2024, 9:33 AM
michal updated the diff for D11351: [web] Migrate crypto store to shared worker.

Added a comment

Mar 19 2024, 9:33 AM
michal added inline comments to D11348: [web] Use crypto store and olm from shared worker.
Mar 19 2024, 9:29 AM
michal updated the diff for D11348: [web] Use crypto store and olm from shared worker.

Fixes, made useTunnelbrokerInitMessage cross-platform.

Mar 19 2024, 9:29 AM
michal updated the diff for D11339: [web/native] Add content outbound session to olmAPI.

Fixes

Mar 19 2024, 9:02 AM
michal updated the diff for D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.

Removed crypto-utils.js as the minimal logic that was there was merged into olmAPI in the previous diffs.

Mar 19 2024, 8:35 AM
michal updated the diff for D11342: [web/native] Move notificationsSessionCreator to olmAPI.

Update with changes from D11319. Removed indirection from native olmAPI.notificationsSessionCreator and make it use the commCoreModule methods directly. The other helper functions will be replaced with the call to the olmAPI in the next diffs.

Mar 19 2024, 8:31 AM
michal updated the diff for D11341: [web] Olm session creation between own devices.

Fixes

Mar 19 2024, 8:29 AM
michal requested review of D11339: [web/native] Add content outbound session to olmAPI.
Mar 19 2024, 8:24 AM
michal updated the diff for D11339: [web/native] Add content outbound session to olmAPI.

Update with changes from D11319. Removed indirection from native olmAPI.contentOutboundSessionCreator. The other helper functions will be replaced with the call to the olmAPI in the next diffs.

Mar 19 2024, 8:24 AM
michal updated the diff for D11338: [web] olmAPI on shared worker.

Fixed the type cast. Improved notification account handling and added a comment that we only need to check one of the accounts.

Mar 19 2024, 8:07 AM
michal added inline comments to D11326: [web] Persist web sessions.
Mar 19 2024, 7:58 AM
michal updated the diff for D11326: [web] Persist web sessions.

Fixes

Mar 19 2024, 7:58 AM
michal requested review of D11353: [web] Replace $FlowFixMe with any.
Mar 19 2024, 7:54 AM
michal requested review of D11352: [web] Deprecate non-worker opaque wasm.
Mar 19 2024, 7:50 AM
michal accepted D11350: [web] Stop setting CSAT on initial redux state action.

We don't want to stop sending the value from the keyserver though, to not reintorduce ENG-6849

Mar 19 2024, 7:26 AM
michal added inline comments to D11351: [web] Migrate crypto store to shared worker.
Mar 19 2024, 7:19 AM
michal requested review of D11351: [web] Migrate crypto store to shared worker.
Mar 19 2024, 6:29 AM
michal accepted D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.

Looks good!

Mar 19 2024, 5:24 AM
michal accepted D11345: [native] Expose backup ct1 and ct2 functions to JS.
Mar 19 2024, 5:17 AM
michal accepted D11344: [native][rust] Split download_backup to separate ct1 and ct2.
Mar 19 2024, 5:14 AM
michal accepted D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

Looks good on the identity-service-client-proxy part.

Mar 19 2024, 5:13 AM

Mar 18 2024

michal requested review of D11348: [web] Use crypto store and olm from shared worker.
Mar 18 2024, 9:09 AM
michal requested review of D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.
Mar 18 2024, 9:06 AM
michal planned changes to D11339: [web/native] Add content outbound session to olmAPI.

Planning changes so I don't forget about handling conflict with D11319

Mar 18 2024, 8:31 AM
michal accepted D11327: [keyserver] Remove deprectaed uses of updateTypes.UPDATE_CURRENT_USER.
Mar 18 2024, 7:14 AM
michal accepted D11328: Implement multiple keyserver unread count on web and desktop on top of IndexedDB.
Mar 18 2024, 7:00 AM
michal updated the diff for D11236: [web] Rename database worker.

Also rename SharedWorkerStatus

Mar 18 2024, 5:13 AM
michal accepted D11304: Refactor notifications sessions storage to support multiple keyservers on web and desktop.
Mar 18 2024, 4:51 AM
michal added inline comments to D11274: [web] Create identity client on shared worker.
Mar 18 2024, 4:41 AM
michal updated the diff for D11274: [web] Create identity client on shared worker.

Fix imports, task created here: ENG-7242

Mar 18 2024, 4:41 AM
michal updated the diff for D11273: [web] Make identity service client runnable on shared worker.

Update name

Mar 18 2024, 4:31 AM
michal updated the diff for D11272: [web] Add cryptoStore to shared worker.

Fixes

Mar 18 2024, 4:25 AM
michal accepted D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.
Mar 18 2024, 4:15 AM

Mar 15 2024

michal requested review of D11342: [web/native] Move notificationsSessionCreator to olmAPI.
Mar 15 2024, 10:56 AM
michal requested review of D11341: [web] Olm session creation between own devices.
Mar 15 2024, 10:53 AM