[web] Persist web sessions
ClosedPublic
Actions

Authored by michal on Mar 14 2024, 4:30 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMd3a410416313: [web] Persist web sessions

Summary

Required for ENG-6657 : Migrate session creation code to shared worker

We need to start persisting web sessions. Notification sessions are going to be persisted in indexedDB as they currently are.

Depends on D11299

Test Plan

Create a dummy session during initalization. Reload web page. Check that the session (runtime object) is no longer there. Initialize the crypto account (rehydrate). Check that the session exists.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Mar 14 2024, 4:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 14 2024, 4:30 AM

michal added inline comments.Mar 14 2024, 4:36 AM

web/shared-worker/types/sqlite-query-executor.js
36 ↗	(On Diff #38059)	If I understand correctly this needs to be changed to `targetDeviceID` right? Is there a task for this? From a quick look the sqlite table column also is named `target_user_id` so this would probably need a migration. But I don't think we depend on this column name anywhere in code (we just treat the values in the table as pairs).

Harbormaster completed remote builds in B27502: Diff 38059.Mar 14 2024, 4:55 AM

michal requested review of this revision.Mar 14 2024, 4:55 AM

michal added a child revision: D11338: [web] olmAPI on shared worker.Mar 15 2024, 10:19 AM

kamil accepted this revision.Mar 18 2024, 5:26 AM

kamil added inline comments.

web/shared-worker/types/sqlite-query-executor.js
36 ↗	(On Diff #38059)	Yes, it should be `targetDeviceID` - could you create a followup task?
web/shared-worker/worker/worker-crypto.js
7–10 ↗	(On Diff #38059)	why this change?
130 ↗	(On Diff #38059)	Can this error be less generic?