Page MenuHomePhabricator

[web/native] Move notificationsSessionCreator to olmAPI
ClosedPublic

Authored by michal on Mar 15 2024, 10:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 3:31 AM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Tue, Oct 15, 2:34 PM
Unknown Object (File)
Oct 9 2024, 6:19 AM
Subscribers

Details

Summary

Part of ENG-6657 : Migrate session creation code to shared worker

Simiarly to D11339 this corresponds to notificationSessionCreator from OlmSessionCreatorContext but without the react-based code (as it doesn't work in the shared worker). The code from OlmSessionCreatorContext will be removed in a future diff.

Depends on D11341

Test Plan

Tested in a later diff but in particular -> checked that the web notifications work and were able to be decrypted using this API to create a session.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil added a reviewer: marcin.

I spoked to @michal and he confirmed that D11299 ensures no two notificationsSessionCreator promises will run simultaneously.

This revision is now accepted and ready to land.Mar 19 2024, 7:17 AM

Update with changes from D11319. Removed indirection from native olmAPI.notificationsSessionCreator and make it use the commCoreModule methods directly. The other helper functions will be replaced with the call to the olmAPI in the next diffs.

Rebase on changes to the notification session creator.