Paths

Table of Contentst

Differential D11372

[web/native] Create tunnelbroker init message on connection
ClosedPublic
Actions

Authored by michal on Mar 22 2024, 8:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 3:27 AM

	Unknown Object (File)
	Thu, Nov 7, 4:10 PM

	Unknown Object (File)
	Thu, Nov 7, 12:59 PM

	Unknown Object (File)
	Thu, Nov 7, 12:38 PM

	Unknown Object (File)
	Thu, Nov 7, 10:38 AM

	Unknown Object (File)
	Wed, Nov 6, 2:56 PM

	Unknown Object (File)
	Oct 15 2024, 2:34 PM

	Unknown Object (File)
	Oct 15 2024, 2:34 PM

View All 64 Files

Subscribers

Details

Reviewers

kamil
tomek
bartek

Commits

rCOMM9e3da11b867f: [web/native] Create tunnelbroker init message on connection

Summary

ENG-6656 : Update the web code to use new cryptoStore

Previously implemented in D11348 but some issues have been noticed and the required changes were large enough that I decided to split them into a separate diff

useTunnelbrokerInitMessage/createTunnelbrokerInitMessage can now we be used cross-platform because of the new web olmAPI so they have been merged into lib TunnelbrokerProvider
Now the tunnelbroker message is created async when making a new tunnelbroker connection which should fix an issue where the deviceID wasn't current

Depends on D11347

Test Plan

Logged into identity -> tunnelbroker connected automatically as auth
Set unauthorizedDeviceID -> tunnelbroker switched connection to unauth
Unset unauthorizedDeviceID -> tunnelbroker switched back to auth connection
Logged out -> tunnelbroker connection was closed

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Mar 22 2024, 8:55 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 22 2024, 8:55 AM

michal added a child revision: D11373: [web] Use shared worker crypto store in identity client provider.Mar 22 2024, 8:59 AM

michal mentioned this in D11348: [web] Use crypto store and olm from shared worker.Mar 22 2024, 9:02 AM

Harbormaster completed remote builds in B27656: Diff 38277.Mar 22 2024, 9:11 AM

michal requested review of this revision.Mar 22 2024, 9:11 AM

kamil accepted this revision.Mar 27 2024, 12:26 AM

kamil added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
160 ↗	(On Diff #38277)	shouldn't we make sure that only one promise runs at a time?

This revision is now accepted and ready to land.Mar 27 2024, 12:26 AM

bartek accepted this revision.Mar 27 2024, 1:01 AM

Made sure that tunnelbroker creation promises run sequentially so the order won't get messed up.

Don't fetch deviceID from worker if we don't have userID or access token anyway.

Harbormaster completed remote builds in B27697: Diff 38354.Mar 27 2024, 4:28 AM

Closed by commit rCOMM9e3da11b867f: [web/native] Create tunnelbroker init message on connection (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 28 2024, 3:58 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM9e3da11b867f: [web/native] Create tunnelbroker init message on connection.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

tunnelbroker-context.js

333 lines

native/

5 lines

utils/

tunnelbroker-utils.js

web/

4 lines

selectors/

tunnelbroker-selectors.js

Diff 38429

lib/tunnelbroker/tunnelbroker-context.js

Loading...

native/root.react.js

Loading...

native/utils/tunnelbroker-utils.js

Loading...

web/app.react.js

Loading...

web/selectors/tunnelbroker-selectors.js

Loading...