Page MenuHomePhabricator

[web] Make identity service client runnable on shared worker
ClosedPublic

Authored by michal on Mar 7 2024, 8:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 1:50 AM
Unknown Object (File)
Tue, Apr 23, 1:49 AM
Unknown Object (File)
Tue, Apr 23, 1:47 AM
Unknown Object (File)
Thu, Apr 11, 11:54 PM
Unknown Object (File)
Fri, Apr 5, 4:55 AM
Unknown Object (File)
Mar 29 2024, 9:18 PM
Unknown Object (File)
Mar 27 2024, 9:55 AM
Unknown Object (File)
Mar 25 2024, 12:03 AM
Subscribers

Details

Summary

[ENG-6766 : Move IdentityServiceClientWrapper to shared worker](https://linear.app/comm/issue/ENG-6766/move-identityserviceclientwrapper-to-shared-worker)

Currently IdentityServiceClientWrapper has two things which don't work on the shared worker:

  • getConfig which is registered only in browser window js context and not worker
  • opaque WASM path needs to be different on webworker (because the inner fetch base origin is different)

this diff changes both of these values to constructor arguments instead of using global context.

Depends on D11272

Test Plan

Make sure logging in to the identity service still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal requested review of this revision.Mar 7 2024, 8:23 AM
kamil added inline comments.
web/grpc/identity-service-client-wrapper.js
45 ↗(On Diff #37931)

this seems more like string - not boolean flag

This revision is now accepted and ready to land.Mar 15 2024, 10:14 AM