Paths

Table of Contentst

-
lib/
-
types/
-
crypto-types.js
-
redux-types.js
-
utils/
-
reducers-utils.test.js
-
web/
-
redux/
-
crypto-store-reducer.js
-
default-state.js
-
persist.js
-
redux-setup.js
-
shared-worker/worker/
-
worker/
-
worker-crypto.js
-
types/
-
worker-types.js

[web] Migrate crypto store to shared worker
ClosedPublic
Actions

Authored by michal on Mar 19 2024, 5:56 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMbe6c43405452: [web] Migrate crypto store to shared worker

Summary

ENG-6655 : Migrate cryptoStore from redux

Previous diffs modified the code so that they use crypto data in shared worker instead of the data in redux. Now we can migrate the crypto accounts from redux to the shared worker.

Depends on D11348

Test Plan

Run migration, make sure that the the data that was in redux matches the data in shared worker. Flow.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Mar 19 2024, 5:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2024, 5:56 AM

Harbormaster completed remote builds in B27580: Diff 38169.Mar 19 2024, 6:29 AM

michal requested review of this revision.Mar 19 2024, 6:29 AM

michal added inline comments.Mar 19 2024, 7:19 AM

web/redux/crypto-store-reducer.js
16–19 ↗	(On Diff #38169)	In these cases the user should get logged out and the database cleanup will be triggered which will clear the crypto store (both the persisted data in db and the in-memory data).

michal added a child revision: D11352: [web] Deprecate non-worker opaque wasm.Mar 19 2024, 7:34 AM

kamil accepted this revision.Mar 19 2024, 8:55 AM

kamil added inline comments.

web/redux/persist.js
265 ↗	(On Diff #38169)	this is because of the fact that at this time `cryptoStore` is not in `AppState` anymore, is that correct?
web/types/worker-types.js
121 ↗	(On Diff #38169)	Would be nice if could add some comment explaining this

This revision is now accepted and ready to land.Mar 19 2024, 8:55 AM

Added a comment

web/redux/persist.js
265 ↗	(On Diff #38169)	Yep

Harbormaster completed remote builds in B27596: Diff 38187.Mar 19 2024, 9:48 AM

Closed by commit rCOMMbe6c43405452: [web] Migrate crypto store to shared worker (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 28 2024, 3:58 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMbe6c43405452: [web] Migrate crypto store to shared worker.

Revision Contents
Changeset List

Path

Size

lib/

types/

crypto-types.js

11 lines

redux-types.js

2 lines

utils/

reducers-utils.test.js

2 lines

web/

redux/

crypto-store-reducer.js

default-state.js

1 line

persist.js

14 lines

redux-setup.js

10 lines

shared-worker/

worker/

worker-crypto.js

4 lines

types/

worker-types.js

16 lines

Diff 38432

View Options

lib/types/crypto-types.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
parseThreadPermissionString,		parseThreadPermissionString,
		constructThreadPermissionString,
includeThreadPermissionForThreadType,		includeThreadPermissionForThreadType,
} from './prefixes.js';		} from './prefixes.js';
import {		import {
configurableCommunityPermissions,		configurableCommunityPermissions,
threadPermissionFilterPrefixes,		threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
userSurfacedPermissions,		userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	if (!parsed.propagationPrefix) {
continue;		continue;
}		}
if (		if (
parsed.propagationPrefix ===		parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT		threadPermissionPropagationPrefixes.DESCENDANT
) {		) {
permissionsForChildren[permissionKey] = permissionValue;		permissionsForChildren[permissionKey] = permissionValue;
}		}
const permissionWithFilterPrefix = parsed.filterPrefix		const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}`		...parsed,
: parsed.permission;		propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue;		});
		permissionsForChildren[withoutPropagationPrefix] = permissionValue;
}		}
if (Object.keys(permissionsForChildren).length === 0) {		if (Object.keys(permissionsForChildren).length === 0) {
return null;		return null;
}		}
return permissionsForChildren;		return permissionsForChildren;
}		}

function getRoleForPermissions(		function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines

View Options

lib/types/redux-types.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
parseThreadPermissionString,		parseThreadPermissionString,
		constructThreadPermissionString,
includeThreadPermissionForThreadType,		includeThreadPermissionForThreadType,
} from './prefixes.js';		} from './prefixes.js';
import {		import {
configurableCommunityPermissions,		configurableCommunityPermissions,
threadPermissionFilterPrefixes,		threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
userSurfacedPermissions,		userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	if (!parsed.propagationPrefix) {
continue;		continue;
}		}
if (		if (
parsed.propagationPrefix ===		parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT		threadPermissionPropagationPrefixes.DESCENDANT
) {		) {
permissionsForChildren[permissionKey] = permissionValue;		permissionsForChildren[permissionKey] = permissionValue;
}		}
const permissionWithFilterPrefix = parsed.filterPrefix		const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}`		...parsed,
: parsed.permission;		propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue;		});
		permissionsForChildren[withoutPropagationPrefix] = permissionValue;
}		}
if (Object.keys(permissionsForChildren).length === 0) {		if (Object.keys(permissionsForChildren).length === 0) {
return null;		return null;
}		}
return permissionsForChildren;		return permissionsForChildren;
}		}

function getRoleForPermissions(		function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines

View Options

lib/utils/reducers-utils.test.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
parseThreadPermissionString,		parseThreadPermissionString,
		constructThreadPermissionString,
includeThreadPermissionForThreadType,		includeThreadPermissionForThreadType,
} from './prefixes.js';		} from './prefixes.js';
import {		import {
configurableCommunityPermissions,		configurableCommunityPermissions,
threadPermissionFilterPrefixes,		threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
userSurfacedPermissions,		userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	if (!parsed.propagationPrefix) {
continue;		continue;
}		}
if (		if (
parsed.propagationPrefix ===		parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT		threadPermissionPropagationPrefixes.DESCENDANT
) {		) {
permissionsForChildren[permissionKey] = permissionValue;		permissionsForChildren[permissionKey] = permissionValue;
}		}
const permissionWithFilterPrefix = parsed.filterPrefix		const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}`		...parsed,
: parsed.permission;		propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue;		});
		permissionsForChildren[withoutPropagationPrefix] = permissionValue;
}		}
if (Object.keys(permissionsForChildren).length === 0) {		if (Object.keys(permissionsForChildren).length === 0) {
return null;		return null;
}		}
return permissionsForChildren;		return permissionsForChildren;
}		}

function getRoleForPermissions(		function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines

View Options

web/redux/crypto-store-reducer.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';

import {		import {
parseThreadPermissionString,		parseThreadPermissionString,
		constructThreadPermissionString,
includeThreadPermissionForThreadType,		includeThreadPermissionForThreadType,
} from './prefixes.js';		} from './prefixes.js';
import {		import {
configurableCommunityPermissions,		configurableCommunityPermissions,
threadPermissionFilterPrefixes,		threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
userSurfacedPermissions,		userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	if (!parsed.propagationPrefix) {
continue;		continue;
}		}
if (		if (
parsed.propagationPrefix ===		parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT		threadPermissionPropagationPrefixes.DESCENDANT
) {		) {
permissionsForChildren[permissionKey] = permissionValue;		permissionsForChildren[permissionKey] = permissionValue;
}		}
const permissionWithFilterPrefix = parsed.filterPrefix		const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}`		...parsed,
: parsed.permission;		propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue;		});
		permissionsForChildren[withoutPropagationPrefix] = permissionValue;
}		}
if (Object.keys(permissionsForChildren).length === 0) {		if (Object.keys(permissionsForChildren).length === 0) {
return null;		return null;
}		}
return permissionsForChildren;		return permissionsForChildren;
}		}

function getRoleForPermissions(		function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines