[web] Add cryptoStore to shared worker
ClosedPublic
Actions

Authored by michal on Mar 7 2024, 7:59 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMfb78b9ed8703: [web] Add cryptoStore to shared worker

Summary

[ENG-6650 : Add cryptoStore to shared worker](https://linear.app/comm/issue/ENG-6650/add-cryptostore-to-shared-worker)

Part of the work to synchronize data between browser tabs. This diff moves the cryptoStore to the shared worker. This is hidden behind the flag for now and will be enabled after all diffs are landed.

The new worker message INITIALIZE_CRYPTO_ACCOUNT also accepts optional cryptoStore which will be used in a future migration
OLM wasm path for webworkers extracted from service worker code

NOTE: currently some parts of olm don't work in the shared worker (more info in the linked issue) but updating our fork will be handled by @kamil.

Depends on D11236

Test Plan

Made sure that olm wasm is downloaded on both dev and in docker (prod)
Tested that initializing crypto account creates and persist new accounts
Tested that if there are persisted accounts they are used instead
Tested that initialCryptoStore ovverides the existing crypto store

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Mar 7 2024, 7:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 7 2024, 7:59 AM

michal added a child revision: D11273: [web] Make identity service client runnable on shared worker.Mar 7 2024, 8:08 AM

Harbormaster completed remote builds in B27387: Diff 37930.Mar 7 2024, 8:13 AM

michal requested review of this revision.Mar 7 2024, 8:13 AM

kamil requested changes to this revision.Mar 11 2024, 4:39 AM

kamil added inline comments.

web/shared-worker/utils/constants.js
52 ↗	(On Diff #37930)	we should rename it, it's confusing with const
web/shared-worker/worker/worker-crypto.js
13 ↗	(On Diff #37930)
16 ↗	(On Diff #37930)	I am not sure if this is the best approach - I think the option will be to store accounts and sessions unpickled in memory to have direct and easy access to crypto operations and pickle only before persisting. What do do you think?
50–53 ↗	(On Diff #37930)	shouldn't these be read-only?

This revision now requires changes to proceed.Mar 11 2024, 4:39 AM

michal added a parent revision: D11324: [web] Move worker database globals to worker-database.js.Mar 14 2024, 4:15 AM

Small fixes
Keep the olm runtime objects directly in memory instead of the pickled form
Create a new separation for olm related requests in worker request types (like in the next diffs for identity client)
Use the globals getters introduced in the previous diff

michal mentioned this in D11274: [web] Create identity client on shared worker.Mar 14 2024, 4:26 AM

Harbormaster completed remote builds in B27498: Diff 38055.Mar 14 2024, 4:33 AM

kamil accepted this revision.Mar 15 2024, 10:10 AM

kamil added inline comments.