[web/native] Move notificationsSessionCreator to olmAPI
ClosedPublic
Actions

Authored by michal on Mar 15 2024, 10:40 AM.

Details

Reviewers

kamil
tomek
marcin

Commits

rCOMMc3489d7b6f5b: [web/native] Move notificationsSessionCreator to olmAPI

Summary

Part of ENG-6657 : Migrate session creation code to shared worker

Simiarly to D11339 this corresponds to notificationSessionCreator from OlmSessionCreatorContext but without the react-based code (as it doesn't work in the shared worker). The code from OlmSessionCreatorContext will be removed in a future diff.

Depends on D11341

Test Plan

Tested in a later diff but in particular -> checked that the web notifications work and were able to be decrypted using this API to create a session.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Mar 15 2024, 10:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 15 2024, 10:40 AM

Harbormaster completed remote builds in B27538: Diff 38107.Mar 15 2024, 10:56 AM

michal requested review of this revision.Mar 15 2024, 10:56 AM

kamil accepted this revision.Mar 18 2024, 6:11 AM

kamil added a reviewer: marcin.

michal added a child revision: D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.Mar 18 2024, 8:50 AM

I spoked to @michal and he confirmed that D11299 ensures no two notificationsSessionCreator promises will run simultaneously.

This revision is now accepted and ready to land.Mar 19 2024, 7:17 AM

Update with changes from D11319. Removed indirection from native olmAPI.notificationsSessionCreator and make it use the commCoreModule methods directly. The other helper functions will be replaced with the call to the olmAPI in the next diffs.

Harbormaster completed remote builds in B27590: Diff 38179.Mar 19 2024, 8:47 AM

michal mentioned this in D11385: [web] Pass platform details to worker.Mar 26 2024, 6:58 AM

michal added a parent revision: D11385: [web] Pass platform details to worker.Mar 26 2024, 6:58 AM

Rebase on changes to the notification session creator.

Harbormaster completed remote builds in B27679: Diff 38327.Mar 26 2024, 7:14 AM

Closed by commit rCOMMc3489d7b6f5b: [web/native] Move notificationsSessionCreator to olmAPI (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 28 2024, 3:55 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMM5bcdfa0eff68: [web] Pass platform details to worker.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMc3489d7b6f5b: [web/native] Move notificationsSessionCreator to olmAPI.