use getExistingDeviceKeyUpload to get the identity keys and prekeys, but not one time keys. note that we do want to generate/send one time keys in secondary device auth so i've left that method alone.
Depends on D11362
Details
Details
logged in from web and confirmed that no new one time keys were added to ddb
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/account/account-hooks.js | ||
|---|---|---|
| 207–239 ↗ | (On Diff #38274) | ENG-6659 tracks changing it for the crypto store. In my stack I already use content for the crypto store storage on the worker. The name "primary" is only kept in type LegacyCryptoStore which is only there so we can type the redux -> shared worker migration. Unrelated to this, from what I have noticed when working on this code is that we also use "primary" in IdentityKeysBlob although I'm not sure how easily fixable this is as I think we sign this objects so this would change the signature? |
| web/shared-worker/worker/worker-crypto.js | ||
| 231 ↗ | (On Diff #38274) | Sorry for the code duplication 🙏. Will try to land the rest of my stack as soon as possible. |
| web/account/account-hooks.js | ||
|---|---|---|
| 207–239 ↗ | (On Diff #38274) | this file is being removed completely in D11347 so i'm going to leave this as-is (consistent with useGetExistingDeviceKeyUpload below) |
| 207–239 ↗ | (On Diff #38274) | you're right that it would change the signature if we renamed the key. probably not worth the effort to update IdentityKeysBlob, IMO |