Page MenuHomePhabricator
Differential D11364

[native] don't generate or send one time keys on login
ClosedPublic
Actions

Authored by varun on Mar 19 2024, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2025, 1:42 AM
Unknown Object (File)
Feb 22 2025, 3:27 AM
Unknown Object (File)
Feb 22 2025, 3:27 AM
Unknown Object (File)
Feb 22 2025, 3:26 AM
Unknown Object (File)
Feb 22 2025, 3:26 AM
Unknown Object (File)
Feb 21 2025, 10:19 PM
Unknown Object (File)
Feb 11 2025, 2:44 PM
Unknown Object (File)
Feb 11 2025, 2:44 PM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
kamil
marcin
ashoat
Commits
rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login
Summary

don't call getOneTimeKeys anymore during identity login. also updated the relevant C++ and Rust code to not expect one-time keys

Depends on D11363

Test Plan

logged in from native and confirmed that no new one time keys were added to ddb

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
8 lines
16 lines
_generated/
identity-service/
32 lines
native_rust_library/
src/
16 lines
schema/
4 lines

Diff 38299

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines connectionChangePromise.current = (async () => {
} }
} else if ( } else if (
message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE
) { ) {
const confirmation: MessageReceiveConfirmation = { const confirmation: MessageReceiveConfirmation = {
type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION, type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION,
messageIDs: [message.messageID], messageIDs: [message.messageID],
}; };
socket.current?.send(JSON.stringify(confirmation));
let rawPeerToPeerMessage; let rawPeerToPeerMessage;
try { try {
rawPeerToPeerMessage = JSON.parse(message.payload); rawPeerToPeerMessage = JSON.parse(message.payload);
} catch (e) { } catch (e) {
console.log( console.log(
'error while parsing Tunnelbroker peer-to-peer message:', 'error while parsing Tunnelbroker peer-to-peer message:',
e.message, e.message,
); );
// Client received incorrect message, confirm to remove from
// Tunnelbroker queue.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) { if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) {
console.log('invalid Tunnelbroker PeerToPeerMessage'); console.log('invalid Tunnelbroker PeerToPeerMessage');
// The client received an invalid Tunnelbroker message,
// and cannot process this type of request.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage; const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage;
currentlyProcessedMessage.current = (async () => { currentlyProcessedMessage.current = (async () => {
const localSocketSessionCounter = socketSessionCounter.current; const localSocketSessionCounter = socketSessionCounter.current;
await currentlyProcessedMessage.current; await currentlyProcessedMessage.current;
// Since scheduling processing this message socket is closed // Since scheduling processing this message socket is closed
// or was closed and reopened, we have to stop processing // or was closed and reopened, we have to stop processing
Show All 9 Lines connectionChangePromise.current = (async () => {
try { try {
await peerToPeerMessageHandler( await peerToPeerMessageHandler(
peerToPeerMessage, peerToPeerMessage,
identityClient, identityClient,
message.messageID, message.messageID,
); );
} catch (e) { } catch (e) {
console.log(e.message); console.log(e.message);
} finally {
if (
localSocketSessionCounter === socketSessionCounter.current &&
socket.current
) {
// We confirm regardless of success or error while processing.
socket.current.send(JSON.stringify(confirmation));
}
} }
})(); })();
} else if ( } else if (
message.type === message.type ===
tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS
) { ) {
for (const status: MessageSentStatus of message.clientMessageIDs) { for (const status: MessageSentStatus of message.clientMessageIDs) {
if (status.type === 'Success') { if (status.type === 'Success') {
▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines connectionChangePromise.current = (async () => {
} }
} else if ( } else if (
message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE
) { ) {
const confirmation: MessageReceiveConfirmation = { const confirmation: MessageReceiveConfirmation = {
type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION, type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION,
messageIDs: [message.messageID], messageIDs: [message.messageID],
}; };
socket.current?.send(JSON.stringify(confirmation));
let rawPeerToPeerMessage; let rawPeerToPeerMessage;
try { try {
rawPeerToPeerMessage = JSON.parse(message.payload); rawPeerToPeerMessage = JSON.parse(message.payload);
} catch (e) { } catch (e) {
console.log( console.log(
'error while parsing Tunnelbroker peer-to-peer message:', 'error while parsing Tunnelbroker peer-to-peer message:',
e.message, e.message,
); );
// Client received incorrect message, confirm to remove from
// Tunnelbroker queue.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) { if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) {
console.log('invalid Tunnelbroker PeerToPeerMessage'); console.log('invalid Tunnelbroker PeerToPeerMessage');
// The client received an invalid Tunnelbroker message,
// and cannot process this type of request.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage; const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage;
currentlyProcessedMessage.current = (async () => { currentlyProcessedMessage.current = (async () => {
const localSocketSessionCounter = socketSessionCounter.current; const localSocketSessionCounter = socketSessionCounter.current;
await currentlyProcessedMessage.current; await currentlyProcessedMessage.current;
// Since scheduling processing this message socket is closed // Since scheduling processing this message socket is closed
// or was closed and reopened, we have to stop processing // or was closed and reopened, we have to stop processing
Show All 9 Lines connectionChangePromise.current = (async () => {
try { try {
await peerToPeerMessageHandler( await peerToPeerMessageHandler(
peerToPeerMessage, peerToPeerMessage,
identityClient, identityClient,
message.messageID, message.messageID,
); );
} catch (e) { } catch (e) {
console.log(e.message); console.log(e.message);
} finally {
if (
localSocketSessionCounter === socketSessionCounter.current &&
socket.current
) {
// We confirm regardless of success or error while processing.
socket.current.send(JSON.stringify(confirmation));
}
} }
})(); })();
} else if ( } else if (
message.type === message.type ===
tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS
) { ) {
for (const status: MessageSentStatus of message.clientMessageIDs) { for (const status: MessageSentStatus of message.clientMessageIDs) {
if (status.type === 'Success') { if (status.type === 'Success') {
▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines connectionChangePromise.current = (async () => {
} }
} else if ( } else if (
message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE
) { ) {
const confirmation: MessageReceiveConfirmation = { const confirmation: MessageReceiveConfirmation = {
type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION, type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION,
messageIDs: [message.messageID], messageIDs: [message.messageID],
}; };
socket.current?.send(JSON.stringify(confirmation));
let rawPeerToPeerMessage; let rawPeerToPeerMessage;
try { try {
rawPeerToPeerMessage = JSON.parse(message.payload); rawPeerToPeerMessage = JSON.parse(message.payload);
} catch (e) { } catch (e) {
console.log( console.log(
'error while parsing Tunnelbroker peer-to-peer message:', 'error while parsing Tunnelbroker peer-to-peer message:',
e.message, e.message,
); );
// Client received incorrect message, confirm to remove from
// Tunnelbroker queue.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) { if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) {
console.log('invalid Tunnelbroker PeerToPeerMessage'); console.log('invalid Tunnelbroker PeerToPeerMessage');
// The client received an invalid Tunnelbroker message,
// and cannot process this type of request.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage; const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage;
currentlyProcessedMessage.current = (async () => { currentlyProcessedMessage.current = (async () => {
const localSocketSessionCounter = socketSessionCounter.current; const localSocketSessionCounter = socketSessionCounter.current;
await currentlyProcessedMessage.current; await currentlyProcessedMessage.current;
// Since scheduling processing this message socket is closed // Since scheduling processing this message socket is closed
// or was closed and reopened, we have to stop processing // or was closed and reopened, we have to stop processing
Show All 9 Lines connectionChangePromise.current = (async () => {
try { try {
await peerToPeerMessageHandler( await peerToPeerMessageHandler(
peerToPeerMessage, peerToPeerMessage,
identityClient, identityClient,
message.messageID, message.messageID,
); );
} catch (e) { } catch (e) {
console.log(e.message); console.log(e.message);
} finally {
if (
localSocketSessionCounter === socketSessionCounter.current &&
socket.current
) {
// We confirm regardless of success or error while processing.
socket.current.send(JSON.stringify(confirmation));
}
} }
})(); })();
} else if ( } else if (
message.type === message.type ===
tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS
) { ) {
for (const status: MessageSentStatus of message.clientMessageIDs) { for (const status: MessageSentStatus of message.clientMessageIDs) {
if (status.type === 'Success') { if (status.type === 'Success') {
▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines connectionChangePromise.current = (async () => {
} }
} else if ( } else if (
message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE message.type === tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE
) { ) {
const confirmation: MessageReceiveConfirmation = { const confirmation: MessageReceiveConfirmation = {
type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION, type: tunnelbrokerMessageTypes.MESSAGE_RECEIVE_CONFIRMATION,
messageIDs: [message.messageID], messageIDs: [message.messageID],
}; };
socket.current?.send(JSON.stringify(confirmation));
let rawPeerToPeerMessage; let rawPeerToPeerMessage;
try { try {
rawPeerToPeerMessage = JSON.parse(message.payload); rawPeerToPeerMessage = JSON.parse(message.payload);
} catch (e) { } catch (e) {
console.log( console.log(
'error while parsing Tunnelbroker peer-to-peer message:', 'error while parsing Tunnelbroker peer-to-peer message:',
e.message, e.message,
); );
// Client received incorrect message, confirm to remove from
// Tunnelbroker queue.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) { if (!peerToPeerMessageValidator.is(rawPeerToPeerMessage)) {
console.log('invalid Tunnelbroker PeerToPeerMessage'); console.log('invalid Tunnelbroker PeerToPeerMessage');
// The client received an invalid Tunnelbroker message,
// and cannot process this type of request.
socket.current?.send(JSON.stringify(confirmation));
return; return;
} }
const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage; const peerToPeerMessage: PeerToPeerMessage = rawPeerToPeerMessage;
currentlyProcessedMessage.current = (async () => { currentlyProcessedMessage.current = (async () => {
const localSocketSessionCounter = socketSessionCounter.current; const localSocketSessionCounter = socketSessionCounter.current;
await currentlyProcessedMessage.current; await currentlyProcessedMessage.current;
// Since scheduling processing this message socket is closed // Since scheduling processing this message socket is closed
// or was closed and reopened, we have to stop processing // or was closed and reopened, we have to stop processing
Show All 9 Lines connectionChangePromise.current = (async () => {
try { try {
await peerToPeerMessageHandler( await peerToPeerMessageHandler(
peerToPeerMessage, peerToPeerMessage,
identityClient, identityClient,
message.messageID, message.messageID,
); );
} catch (e) { } catch (e) {
console.log(e.message); console.log(e.message);
} finally {
if (
localSocketSessionCounter === socketSessionCounter.current &&
socket.current
) {
// We confirm regardless of success or error while processing.
socket.current.send(JSON.stringify(confirmation));
}
} }
})(); })();
} else if ( } else if (
message.type === message.type ===
tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS tunnelbrokerMessageTypes.MESSAGE_TO_DEVICE_REQUEST_STATUS
) { ) {
for (const status: MessageSentStatus of message.clientMessageIDs) { for (const status: MessageSentStatus of message.clientMessageIDs) {
if (status.type === 'Success') { if (status.type === 'Success') {
▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...