[native] don't generate or send one time keys on login
ClosedPublic
Actions

Authored by varun on Mar 20 2024, 1:29 AM.

Details

Reviewers

bartek
kamil
marcin
ashoat

Commits

rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login

Summary

don't call getOneTimeKeys anymore during identity login. also updated the relevant C++ and Rust code to not expect one-time keys

Depends on D11363

Test Plan

logged in from native and confirmed that no new one time keys were added to ddb

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 20 2024, 1:29 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 20 2024, 1:29 AM

varun added a reviewer: ashoat.Mar 20 2024, 1:39 AM

Harbormaster completed remote builds in B27621: Diff 38217.Mar 20 2024, 1:44 AM

varun requested review of this revision.Mar 20 2024, 1:44 AM

ashoat accepted this revision.Mar 20 2024, 6:08 PM

This revision is now accepted and ready to land.Mar 20 2024, 6:08 PM

bartek accepted this revision.Mar 21 2024, 9:50 AM

Closed by commit rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login. · Explain WhyMar 25 2024, 7:52 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

8 lines

CommRustModule.cpp

16 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

identity-service/

identity-service-context-provider.react.js

32 lines

native_rust_library/

src/

lib.rs

16 lines

schema/

CommRustModuleSchema.js

4 lines

Diff 38217

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/identity-service/identity-service-context-provider.react.js

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommRustModuleSchema.js

[native] don't generate or send one time keys on loginClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38217

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

[native] don't generate or send one time keys on login
ClosedPublic
Actions

Revision Contents
Changeset List