[web] Stop setting CSAT on initial redux state action
ClosedPublic
Actions

Authored by inka on Mar 19 2024, 5:28 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM31f3b9f2cdd2: [web] Stop setting CSAT on initial redux state action

Summary

issue: ENG-6919
From D9122 it looks like commServicesAccessToken: null is sent from the keyserver as a result of decoupling web app and keyserver data. And back when keyserver would send all state fields in initial redux state with web app, we were just using the default null. So it looks like it wasn't supposed to do anything, it's just the default.

But because we were sending commServicesAccessToken: null, and initial redux state is being spread in the reducer, the CSAT would get set to null when the app was reloaded.
We don't want to stop sending the value from the keyserver though, to not reintorduce ENG-6849

Test Plan

Tested that in multikeyserver setup, CSAT is no longer set ot null after app is reloaded

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mar 19 2024, 5:28 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2024, 5:28 AM

Harbormaster completed remote builds in B27579: Diff 38168.Mar 19 2024, 5:48 AM

inka requested review of this revision.Mar 19 2024, 5:48 AM

We don't want to stop sending the value from the keyserver though, to not reintorduce ENG-6849

I think we actually could stop sending the value from the keyserver. useGetInitialReduxState is only called when a new webapp is initialized. And at this point this will be a new webapp which can handle the lack of commServicesAccessToken in the payload.

This revision is now accepted and ready to land.Mar 19 2024, 7:26 AM

Stop sending commServicesAccessToken from keyserver

Harbormaster completed remote builds in B27591: Diff 38180.Mar 19 2024, 8:48 AM

Closed by commit rCOMM31f3b9f2cdd2: [web] Stop setting CSAT on initial redux state action (authored by inka). · Explain WhyMar 19 2024, 8:51 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM31f3b9f2cdd2: [web] Stop setting CSAT on initial redux state action.