[lib][web][native] Use uuid for next local id
ClosedPublic
Actions

Authored by inka on Thu, Apr 4, 7:16 AM.

Details

Reviewers

michal
ginsu

Commits

rCOMMf2ad39d004ef: [lib][web][native] Use uuid for next local id

Summary

issues: ENG-6074 and ENG-6075
We want to start using uuid in place of manually calculated local id.

Test Plan

Tested (on native) that it is possible to create events, send text messages, send multimedia, react

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Thu, Apr 4, 7:16 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 4, 7:16 AM

inka mentioned this in D11553: [lib][web][native] Remove nextLocalID from redux.Thu, Apr 4, 7:19 AM

inka added a child revision: D11553: [lib][web][native] Remove nextLocalID from redux.Thu, Apr 4, 7:20 AM

Harbormaster completed remote builds in B27975: Diff 38772.Thu, Apr 4, 7:31 AM

inka requested review of this revision.Thu, Apr 4, 7:31 AM

michal accepted this revision.Thu, Apr 4, 7:58 AM

This revision is now accepted and ready to land.Thu, Apr 4, 7:58 AM

Closed by commit rCOMMf2ad39d004ef: [lib][web][native] Use uuid for next local id (authored by inka). · Explain WhyFri, Apr 5, 3:43 AM

This revision was automatically updated to reflect the committed changes.

inka mentioned this in rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux.

inka added a commit: rCOMMf2ad39d004ef: [lib][web][native] Use uuid for next local id.

michal mentioned this in D11539: [web] Persist messageStore in db.Fri, Apr 5, 3:50 AM

Revision Contents
Changeset List

Path

Size

lib/

actions/

entry-actions.js

6 lines

shared/

message-utils.js

7 lines

native/

calendar/

thread-picker-modal.react.js

5 lines

chat/

chat-input-bar.react.js

7 lines

inline-engagement.react.js

4 lines

multimedia-message-tooltip-button.react.js

3 lines

reaction-message-utils.js

5 lines

robotext-message-tooltip-button.react.js

3 lines

text-message-tooltip-button.react.js

3 lines

input/

input-state-container.react.js

7 lines

web/

calendar/

day.react.js

10 lines

chat/

chat-input-bar.react.js

19 lines

reaction-message-utils.js

5 lines

reaction-pill.react.js

4 lines

input/

input-state-container.react.js

11 lines

input-state.js

2 lines

tooltips/

message-tooltip.react.js

4 lines

Diff 38850

View Options

lib/actions/entry-actions.js

View Options

lib/shared/message-utils.js

View Options

native/calendar/thread-picker-modal.react.js

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/multimedia-message-tooltip-button.react.js

View Options

native/chat/reaction-message-utils.js

View Options

native/chat/robotext-message-tooltip-button.react.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

native/input/input-state-container.react.js

View Options

web/calendar/day.react.js

View Options

web/chat/chat-input-bar.react.js

View Options

web/chat/reaction-message-utils.js

View Options

web/chat/reaction-pill.react.js

View Options

web/input/input-state-container.react.js

View Options

web/input/input-state.js

View Options

web/tooltips/message-tooltip.react.js

[lib][web][native] Use uuid for next local idClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38850

lib/actions/entry-actions.js

lib/shared/message-utils.js

native/calendar/thread-picker-modal.react.js

native/chat/chat-input-bar.react.js

native/chat/inline-engagement.react.js

native/chat/multimedia-message-tooltip-button.react.js

native/chat/reaction-message-utils.js

native/chat/robotext-message-tooltip-button.react.js

native/chat/text-message-tooltip-button.react.js

native/input/input-state-container.react.js

web/calendar/day.react.js

web/chat/chat-input-bar.react.js

web/chat/reaction-message-utils.js

web/chat/reaction-pill.react.js

web/input/input-state-container.react.js

web/input/input-state.js

web/tooltips/message-tooltip.react.js

[lib][web][native] Use uuid for next local id
ClosedPublic
Actions

Revision Contents
Changeset List