Page MenuHomePhabricator
Differential D11553

[lib][web][native] Remove nextLocalID from redux
ClosedPublic
Actions

Authored by inka on Thu, Apr 4, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 11:08 AM
Unknown Object (File)
Thu, Apr 11, 2:22 AM
Unknown Object (File)
Wed, Apr 10, 10:32 PM
Unknown Object (File)
Wed, Apr 10, 10:20 PM
Unknown Object (File)
Wed, Apr 10, 9:27 PM
Unknown Object (File)
Wed, Apr 10, 6:23 PM
Unknown Object (File)
Wed, Apr 10, 5:32 PM
Unknown Object (File)
Wed, Apr 10, 5:22 PM
View All 14 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
ginsu
Commits
rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux
Summary

issue: ENG-6076
This field is nolonger used after D11552

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Thu, Apr 4, 7:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 4, 7:19 AM
inka added a parent revision: D11552: [lib][web][native] Use uuid for next local id.Thu, Apr 4, 7:20 AM
Harbormaster completed remote builds in B27976: Diff 38773.Thu, Apr 4, 7:33 AM
inka requested review of this revision.Thu, Apr 4, 7:33 AM
michal accepted this revision.Thu, Apr 4, 8:07 AM
michal added inline comments.
native/redux/state-types.js
66 ↗(On Diff #38773)

Don't we need a migration to remove it so we don't get the alert with the unexpected key rehydrated? Or is it fine?

This revision is now accepted and ready to land.Thu, Apr 4, 8:07 AM
inka updated this revision to Diff 38779.Thu, Apr 4, 9:02 AM

Add migration

Harbormaster completed remote builds in B27977: Diff 38779.Thu, Apr 4, 9:18 AM
inka updated this revision to Diff 38845.Fri, Apr 5, 3:09 AM

Rebase

inka added a child revision: D11564: [lib] Fix sorting local messages.Fri, Apr 5, 3:28 AM
Harbormaster completed remote builds in B28018: Diff 38845.Fri, Apr 5, 3:38 AM
Closed by commit rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux (authored by inka). · Explain WhyFri, Apr 5, 3:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux.

Revision Contents
Changeset List

PathSize
lib/
reducers/
2 lines
types/
1 line
utils/
3 lines
native/
redux/
1 line
6 lines
2 lines
web/
redux/
1 line
2 lines

Diff 38849

View Options

lib/reducers/local-id-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/redux-setup.js

Loading...