Paths

Table of Contentst

Differential D11545

[web/native/lib] Use message pruner on web
ClosedPublic
Actions

Authored by michal on Wed, Apr 3, 7:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 11:03 AM

	Unknown Object (File)
	Mon, Apr 15, 8:08 PM

	Unknown Object (File)
	Thu, Apr 11, 8:12 AM

	Unknown Object (File)
	Wed, Apr 10, 2:31 PM

	Unknown Object (File)
	Tue, Apr 9, 10:02 PM

	Unknown Object (File)
	Mon, Apr 8, 7:26 PM

	Unknown Object (File)
	Mon, Apr 8, 7:26 PM

	Unknown Object (File)
	Mon, Apr 8, 2:19 PM

View All 12 Files

Subscribers

Details

Reviewers

atul
kamil
marcin

Commits

rCOMMa77e7bf193ca: [web/native/lib] Use message pruner on web

Summary

ENG-3475 : Implement message pruner for the web
Now that messages will be persisted on web we should prun them occasionaly. This moves MessageStorePruner, nextMessagePruneTimeSelector and pruneThreadIDsSelector from native to lib and removes the platform-specific code, which now lives in native/web.

Also fixes an issue mentioned in this comment by ignoring threads with less than 20 messages in nextMessagePruneTimeSelector.

Depends on D11544

Test Plan

Change the msInHour constant to a lower value so pruning happens more often. Test on both web and native that the threads with <20 messages get pruned. Test that this doesn't cause issues on web (e.g. the messages can still be fetched from keyserver).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Wed, Apr 3, 7:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 3, 7:40 AM

Harbormaster completed remote builds in B27955: Diff 38735.Wed, Apr 3, 7:55 AM

michal requested review of this revision.Wed, Apr 3, 7:55 AM

atul accepted this revision.Thu, Apr 4, 12:17 PM

atul retitled this revision from [web/native/lib] Use message prunner on web to [web/native/lib] Use message pruner on web.

This revision is now accepted and ready to land.Thu, Apr 4, 12:18 PM

ashoat added inline comments.Thu, Apr 4, 2:50 PM

lib/selectors/message-selector.js
26–32 ↗	(On Diff #38735)	Context for this here

kamil accepted this revision.Fri, Apr 5, 3:42 AM

kamil added inline comments.

lib/selectors/message-selector.js
6–7 ↗	(On Diff #38735)	can be merged

Merge imports

Harbormaster completed remote builds in B28026: Diff 38855.Fri, Apr 5, 5:57 AM

Closed by commit rCOMMa77e7bf193ca: [web/native/lib] Use message pruner on web (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFri, Apr 5, 9:45 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa77e7bf193ca: [web/native/lib] Use message pruner on web.

Revision Contents
Changeset List

Path

Size

	lib/
	native/

	components/
	chat/

message-store-pruner.react.js

39 lines

selectors/

	message-selector.js
	message-selectors.js

38 lines

native/

chat/

12 lines

message-store-pruner.react.js

selectors/

message-selectors.js

web/

chat/

6 lines

Diff 38870

lib/components/message-store-pruner.react.js

Loading...

lib/selectors/message-selector.js

Loading...

native/chat/chat.react.js

Loading...

native/chat/message-store-pruner.react.js

Loading...

native/selectors/message-selectors.js

Loading...

web/chat/chat.react.js

Loading...