Page MenuHomePhabricator

[lib][web][native] Handle idnentity login in reducers
ClosedPublic

Authored by inka on Mar 27 2024, 4:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 9:59 PM
Unknown Object (File)
Fri, Apr 19, 9:59 PM
Unknown Object (File)
Fri, Apr 19, 9:59 PM
Unknown Object (File)
Fri, Apr 19, 9:58 PM
Unknown Object (File)
Tue, Apr 16, 5:15 AM
Unknown Object (File)
Tue, Apr 16, 1:59 AM
Unknown Object (File)
Mon, Apr 15, 5:44 PM
Unknown Object (File)
Sat, Apr 13, 1:56 AM
Subscribers

Details

Summary

issues: ENG-6598 and ENG-6639

We want to wipe the state on identity login. More context in ENG-6424
We also need to save the CSAT (some further discussion in ENG-7428)
Same as in D10860 we want to set the calendar query in the reducer to use the current dates

Test Plan

Tested that the state is wiped on normal login. Tested that the state is not wiped on recovery login

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Mar 27 2024, 4:27 AM
lib/reducers/services-access-token-reducer.js
29–32 ↗(On Diff #38353)

Strange to see this added here and then removed in a later diff in the stack

lib/reducers/services-access-token-reducer.js
29–32 ↗(On Diff #38353)

I felt like this would make reviewing easier, as those two diffs have quite different purposes.
This diff implements logic for login, following what we already have in the code for registration. This is code we know works, we are just implementing it for an action that was recently added.
The next diff refactors this logic. The refactor is due to us having rethought some general app design, and is more likely to be questioned and possibly changed drastically or abandoned.
So I wanted to have this first diff that can be safely landed before we agree on the second diff. This is also partially because the second diff was not in the initial scope of my goal.

lib/reducers/services-access-token-reducer.js
29–32 ↗(On Diff #38353)

Okay, fair enough!

This revision is now accepted and ready to land.Thu, Mar 28, 7:21 AM