Paths

Table of Contentst

Differential D11738

[lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native
ClosedPublic
Actions

Authored by inka on Tue, Apr 23, 4:38 AM.

Tags

None

Referenced Files

	F1695065: D11738.id39493.diff
	Fri, May 3, 1:35 AM

	Unknown Object (File)
	Thu, May 2, 1:32 PM

	Unknown Object (File)
	Wed, May 1, 3:51 PM

	Unknown Object (File)
	Mon, Apr 29, 6:03 PM

	Unknown Object (File)
	Mon, Apr 29, 3:00 PM

	Unknown Object (File)
	Sun, Apr 28, 9:35 AM

	Unknown Object (File)
	Fri, Apr 26, 7:17 PM

	Unknown Object (File)
	Wed, Apr 24, 2:39 PM

View All 10 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMMa05e97f0976b: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to…

Summary

issue: ENG-7898
Now that this reducer reduces only setAccessTokenActionType , we can move this logic to native, since web doesn't use this action.

Test Plan

Tested that on web CSAT is cleared on logout, and is present when user is logged in
Tested that on logout CSAT is set to an empty string on native
Tested that on login CSAT is set to a non empty string on native
Tested that if setNewSessionActionType with cookieInvalidated is dispatched, then the user is logged out and the CSAT is cleared

+flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Tue, Apr 23, 4:38 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Apr 23, 4:38 AM

inka added a parent revision: D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.Tue, Apr 23, 4:39 AM

Harbormaster completed remote builds in B28401: Diff 39396.Tue, Apr 23, 4:54 AM

inka requested review of this revision.Tue, Apr 23, 4:54 AM

tomek accepted this revision.Wed, Apr 24, 3:57 AM

This revision is now accepted and ready to land.Wed, Apr 24, 3:57 AM

inka added a child revision: D11759: [lib][native] Stop persisting CSAT.Wed, Apr 24, 7:07 AM

Closed by commit rCOMMa05e97f0976b: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to… (authored by inka). · Explain WhyThu, Apr 25, 8:43 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa05e97f0976b: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to….

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

3 lines

reducers/

master-reducer.js

5 lines

services-access-token-reducer.js

types/

4 lines

native/

components/

access-token-handler.react.js

2 lines

redux/

action-types.js

4 lines

3 lines

Diff 39493

lib/actions/user-actions.js

Loading...

lib/reducers/master-reducer.js

Loading...

lib/reducers/services-access-token-reducer.js

Loading...

lib/types/redux-types.js

Loading...

native/components/access-token-handler.react.js

Loading...

native/redux/action-types.js

Loading...

native/redux/redux-setup.js

Loading...