Paths

Table of Contentst

[native] Expose backup ct1 and ct2 functions to JS
ClosedPublic
Actions

Authored by bartek on Mar 18 2024, 3:59 AM.

Details

Reviewers

michal
kamil

Commits

rCOMMbda9552147ac: [native] Expose backup ct1 and ct2 functions to JS

Summary

In addition to restoreBackup(), exposed functions that separately get backup keys and data via JSI. They're needed for secondary device auth

Depends on D11344

Test Plan

Modified backupRestoreProtocol in useClientBackup to call retrieveBackupKeys and then restoreBackupData, instead of single restoreBackup() call.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 18 2024, 3:59 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 18 2024, 3:59 AM

Harbormaster failed remote builds in B27545: Diff 38116!Mar 18 2024, 4:13 AM

bartek added a child revision: D11346: [lib][native] Call backup restore protocol after QR auth.Mar 18 2024, 4:31 AM

Fix typo

bartek published this revision for review.Mar 18 2024, 5:10 AM

Harbormaster completed remote builds in B27550: Diff 38121.Mar 18 2024, 5:12 AM

michal accepted this revision.Mar 19 2024, 5:17 AM

This revision is now accepted and ready to land.Mar 19 2024, 5:17 AM

Closed by commit rCOMMbda9552147ac: [native] Expose backup ct1 and ct2 functions to JS (authored by bartek). · Explain WhyMar 21 2024, 4:29 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbda9552147ac: [native] Expose backup ct1 and ct2 functions to JS.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

7 lines

CommCoreModule.cpp

31 lines

_generated/

commJSI-generated.cpp

commJSI.h

native_rust_library/

src/

backup.rs

71 lines

lib.rs

11 lines

schema/

CommCoreModuleSchema.js

6 lines

Diff 38256

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommCoreModuleSchema.js

[native] Expose backup ct1 and ct2 functions to JSClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38256

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/native_rust_library/src/backup.rs

native/native_rust_library/src/lib.rs

native/schema/CommCoreModuleSchema.js

[native] Expose backup ct1 and ct2 functions to JS
ClosedPublic
Actions

Revision Contents
Changeset List