[web][native] Encrypt QR auth messages with AES
ClosedPublic
Actions

Authored by bartek on Mar 14 2024, 10:42 AM.

Details

Reviewers

kamil
michal

Commits

rCOMM920c30f7b3d1: [web][native] Encrypt QR auth messages with AES

Summary

Refactored functions for composing and parsing Tunnelbroker QR auth messages to use AES-256 encryption, instead of plaintext JSON stringify/parse.

This required separating them for web/native, due to platform-specific implementations of AES encryption. Also needed to implement some minor helpers for web that were already present on native.

Depends on D11331

Test Plan

Still able to perform QR code auth on both web and native. Added unit tests for helpers on web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 14 2024, 10:42 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 14 2024, 10:42 AM

Harbormaster completed remote builds in B27518: Diff 38083.Mar 14 2024, 11:00 AM

bartek published this revision for review.Mar 18 2024, 12:33 AM

bartek added a child revision: D11344: [native][rust] Split download_backup to separate ct1 and ct2.Mar 18 2024, 3:55 AM

Rebase

Harbormaster completed remote builds in B27560: Diff 38131.Mar 18 2024, 5:50 AM

Exciting!!

lib/components/qr-auth-handler.react.js
23–33 ↗	(On Diff #38131)	Would be good to make all of these props read-only

kamil accepted this revision.Mar 19 2024, 5:57 AM

kamil added inline comments.

native/qr-code/qr-code-utils.js
49 ↗	(On Diff #38131)	shouldn't we reject here?

This revision is now accepted and ready to land.Mar 19 2024, 5:57 AM

bartek added inline comments.Mar 21 2024, 3:44 AM

native/qr-code/qr-code-utils.js
49 ↗	(On Diff #38131)	I think not. We intentionally return null to ignore such messages. This simplifies backward compatibility when adding more message types in the future