Part of QR code auth flow - primary device performs device list update after the QR code is scanned. Then it notifies the secondary device that it can continue.
Depends on D11293
Details
Details
- Reviewers
kamil michal - Commits
- rCOMM9342eac75a6f: [native] Update device list on QR code scaned
Ran the app on both simulator and physical phone - scanned QR code and made sure that Identity Service receives updated device list (checked the DDB table)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/profile/secondary-device-qr-code-scanner.react.js | ||
|---|---|---|
| 56 ↗ | (On Diff #38013) | Should we add an invariant above this line that deviceLists.length > 0? Otherwise the error may not be very informative |
| 70 ↗ | (On Diff #38013) | It doesn't affect like the return value is used in this diff. Is it really necessary? |
| native/profile/secondary-device-qr-code-scanner.react.js | ||
|---|---|---|
| 40 ↗ | (On Diff #38013) | I think I saw this invariant in our codebase right after React.useContext but I might be wrong |
| 62–73 ↗ | (On Diff #38013) | |
| 111 ↗ | (On Diff #38013) | I think this make is easier to understand |
| 113 ↗ | (On Diff #38013) | Why not make onConnect async function? |
| native/profile/secondary-device-qr-code-scanner.react.js | ||
|---|---|---|
| 40 ↗ | (On Diff #38013) | Yeah it can be moved - we'll see the error sooner if it ever happens |
| 56 ↗ | (On Diff #38013) | Good call |
| 70 ↗ | (On Diff #38013) | It was mostly needed for debugging, to see if the device list was actually updated or not. I can get rid of the return value for now |