Page MenuHomePhabricator
Differential D8974

[services-lib][blob-client] Use Bytes instead of Vec<u8>
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:14 AM
Unknown Object (File)
Wed, Mar 26, 11:14 AM
Unknown Object (File)
Wed, Mar 26, 11:14 AM
Unknown Object (File)
Wed, Mar 26, 5:48 AM
Unknown Object (File)
Sun, Mar 16, 11:58 PM
Unknown Object (File)
Wed, Mar 5, 2:07 AM
Unknown Object (File)
Tue, Mar 4, 6:13 PM
Unknown Object (File)
Tue, Mar 4, 6:13 PM
View All 97 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• jon
Commits
rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>
Summary

Partially overlaps with D8964 - we should use Bytes instead of Vec<u8> for blob data to avoid unnecessary allocations.

Also added the bytes dependency to services-lib and re-exported it.

Depends on D8786

Test Plan

Tested together with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
comm-services-lib/
8 lines
src/
blob/
14 lines
9 lines
reports/

Diff 30519

View Options

services/backup/Cargo.lock

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/comm-services-lib/Cargo.lock

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/comm-services-lib/Cargo.toml

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/comm-services-lib/src/blob/client.rs

Show All 37 Lines
) )
if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker") if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
# Inside the docker build contex # Inside the docker build contex
set(_proto_path "grpc") set(_proto_path "grpc")
set(_shared_path "../shared") set(_shared_path "../shared")
else() else()
# Inside repo # Inside repo
set(_proto_path "../../native/cpp/CommonCpp/grpc")
set(_shared_path "../../shared") set(_shared_path "../../shared")
set(_proto_path "../../shared/protos")
endif() endif()
# Shared Comm protos # Shared Comm protos
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path} add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
${CMAKE_CURRENT_BINARY_DIR}/protos ${CMAKE_CURRENT_BINARY_DIR}/protos
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
) )
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/comm-services-lib/src/lib.rs

Loading...
View Options

services/reports/Cargo.lock

Loading...