Paths

Table of Contentst

Differential D8964

[backup] Introduce download endpoints
ClosedPublic
Actions

Authored by michal on Aug 28 2023, 1:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 7:42 PM

	Unknown Object (File)
	Sat, Dec 14, 7:42 PM

	Unknown Object (File)
	Sat, Dec 14, 7:41 PM

	Unknown Object (File)
	Sat, Dec 14, 7:30 PM

	Unknown Object (File)
	Mon, Nov 25, 7:08 PM

	Unknown Object (File)
	Nov 22 2024, 6:59 PM

	Unknown Object (File)
	Nov 22 2024, 8:20 AM

	Unknown Object (File)
	Oct 27 2024, 5:01 PM

View All 74 Files

Subscribers

Details

Reviewers

bartek
• patryk
kamil
• jon

Commits

rCOMM02d2d035d2ed: [backup] Introduce download endpoints

Summary

Endpoints for downloading backup blobs: user_keys and user_data.

Test Plan

Run:

GET http://127.0.0.1:50052/backups/id7/user_keys
Authorization: Bearer eyJ1c2VySUQiOiAiMSIsICJhY2Nlc3NUb2tlbiI6ICIyIiwgImRldmljZUlEIjogIjMifQ==

GET http://127.0.0.1:50052/backups/id7/user_data
Authorization: Bearer eyJ1c2VySUQiOiAiMSIsICJhY2Nlc3NUb2tlbiI6ICIyIiwgImRldmljZUlEIjogIjMifQ==

Test if the returned data is correct. Run with non-existant backup id, check if 404 is returned.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 28 2023, 1:49 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 1:49 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

michal added a parent revision: D8963: [backup] Introduce upload endpoint.Aug 28 2023, 1:49 AM

michal added inline comments.

services/comm-services-lib/src/blob/client.rs
87 ↗	(On Diff #30422)	Modified so we don't have to unnecessarily allocate a vec.

michal added a child revision: D8965: [backup] Implement download latest endpoints.Aug 28 2023, 2:01 AM

Harbormaster completed remote builds in B22156: Diff 30422.Aug 28 2023, 2:07 AM

michal requested review of this revision.Aug 28 2023, 2:07 AM

bartek mentioned this in D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 28 2023, 4:06 AM

bartek accepted this revision.Aug 28 2023, 5:28 AM

This revision is now accepted and ready to land.Aug 28 2023, 5:28 AM

kamil mentioned this in D8990: [client-backup] add backup-service facts.Aug 29 2023, 2:04 AM

bartek mentioned this in rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 29 2023, 11:24 AM

Closed by commit rCOMM02d2d035d2ed: [backup] Introduce download endpoints (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM02d2d035d2ed: [backup] Introduce download endpoints.

kamil mentioned this in rCOMM84ce71bd0714: [client-backup] add backup-service facts.Aug 30 2023, 11:29 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

2 lines

src/

database/

21 lines

4 lines

http/

handlers/

63 lines

19 lines

Diff 30531

services/backup/Cargo.lock

Loading...

services/backup/Cargo.toml

Loading...

services/backup/src/database/mod.rs

Loading...

services/backup/src/error.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/mod.rs

Loading...