Page MenuHomePhabricator
Differential D8964

[backup] Introduce download endpoints
ClosedPublic
Actions

Authored by michal on Aug 28 2023, 1:49 AM.
Tags
None
Referenced Files
F5054119: D8964.id30531.diff
Tue, Mar 25, 4:16 AM
Unknown Object (File)
Sun, Mar 23, 9:26 PM
Unknown Object (File)
Sun, Mar 16, 11:58 PM
Unknown Object (File)
Wed, Mar 5, 9:43 AM
Unknown Object (File)
Tue, Mar 4, 6:14 PM
Unknown Object (File)
Tue, Mar 4, 6:14 PM
Unknown Object (File)
Tue, Mar 4, 6:13 PM
Unknown Object (File)
Tue, Mar 4, 6:07 PM
View All 88 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
• patryk
kamil
• jon
Commits
rCOMM02d2d035d2ed: [backup] Introduce download endpoints
Summary

ENG-4501

Endpoints for downloading backup blobs: user_keys and user_data.

Test Plan

Run:

GET http://127.0.0.1:50052/backups/id7/user_keys
Authorization: Bearer eyJ1c2VySUQiOiAiMSIsICJhY2Nlc3NUb2tlbiI6ICIyIiwgImRldmljZUlEIjogIjMifQ==

GET http://127.0.0.1:50052/backups/id7/user_data
Authorization: Bearer eyJ1c2VySUQiOiAiMSIsICJhY2Nlc3NUb2tlbiI6ICIyIiwgImRldmljZUlEIjogIjMifQ==

Test if the returned data is correct. Run with non-existant backup id, check if 404 is returned.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Aug 28 2023, 1:49 AM
Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 1:49 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
michal added a parent revision: D8963: [backup] Introduce upload endpoint.Aug 28 2023, 1:49 AM
michal added inline comments.
services/comm-services-lib/src/blob/client.rs
87 ↗(On Diff #30422)

Modified so we don't have to unnecessarily allocate a vec.

michal added a child revision: D8965: [backup] Implement download latest endpoints.Aug 28 2023, 2:01 AM
Harbormaster completed remote builds in B22156: Diff 30422.Aug 28 2023, 2:07 AM
michal requested review of this revision.Aug 28 2023, 2:07 AM
bartek mentioned this in D8974: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 28 2023, 4:06 AM
bartek accepted this revision.Aug 28 2023, 5:28 AM
This revision is now accepted and ready to land.Aug 28 2023, 5:28 AM
kamil mentioned this in D8990: [client-backup] add backup-service facts.Aug 29 2023, 2:04 AM
bartek mentioned this in rCOMM758d5a4d6450: [services-lib][blob-client] Use Bytes instead of Vec<u8>.Aug 29 2023, 11:24 AM
Closed by commit rCOMM02d2d035d2ed: [backup] Introduce download endpoints (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM02d2d035d2ed: [backup] Introduce download endpoints.
kamil mentioned this in rCOMM84ce71bd0714: [client-backup] add backup-service facts.Aug 30 2023, 11:29 AM

Revision Contents
Changeset List

PathSize
services/
backup/
2 lines
src/
database/
21 lines
4 lines
http/
handlers/
63 lines
19 lines

Diff 30531

View Options

services/backup/Cargo.lock

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/backup/Cargo.toml

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/backup/src/database/mod.rs

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/backup/src/error.rs

Show All 17 Lines
# Find AMQP-CPP installation # Find AMQP-CPP installation
find_package(amqpcpp CONFIG REQUIRED) find_package(amqpcpp CONFIG REQUIRED)
# Find Cryptopp installation # Find Cryptopp installation
pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6) pkg_check_modules(CRYPTOPP REQUIRED libcryptopp=8.6)
# Find Libuv installation # Find Libuv installation
pkg_check_modules(LIBUV REQUIRED libuv=1.43.0) pkg_check_modules(LIBUV REQUIRED libuv>=1.43)
set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE) set(BUILD_TESTING OFF CACHE BOOL "Turn off tests" FORCE)
set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE) set(WITH_GFLAGS OFF CACHE BOOL "Turn off gflags" FORCE)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb) find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED) find_package(Boost 1.40 COMPONENTS program_options thread system REQUIRED)
find_package(OpenSSL REQUIRED) find_package(OpenSSL REQUIRED)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

services/backup/src/http/mod.rs

Loading...