Page MenuHomePhabricator
Differential D8953

[backup] Split database module
ClosedPublic
Actions

Authored by michal on Aug 25 2023, 9:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 2:14 PM
Unknown Object (File)
Mon, Mar 24, 2:14 PM
Unknown Object (File)
Mon, Mar 24, 2:14 PM
Unknown Object (File)
Mon, Mar 24, 2:14 PM
Unknown Object (File)
Sun, Mar 23, 1:41 PM
Unknown Object (File)
Tue, Mar 18, 10:49 PM
Unknown Object (File)
Sun, Mar 16, 11:58 PM
Unknown Object (File)
Thu, Mar 6, 10:05 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
• patryk
kamil
• jon
Commits
rCOMM0969a32f4c4c: [backup] Split database module
Summary

ENG-4380
No code changes, just separating code so it's easier to parse.

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Aug 25 2023, 9:50 AM
Herald added a reviewer: • jon. · View Herald TranscriptAug 25 2023, 9:50 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
michal added a parent revision: D8952: [backup] Introduce backup error.Aug 25 2023, 9:50 AM
michal added a child revision: D8954: [backup] Update dynamodb.Aug 25 2023, 9:54 AM
Harbormaster completed remote builds in B22094: Diff 30328.Aug 25 2023, 10:07 AM
michal requested review of this revision.Aug 25 2023, 10:07 AM
bartek accepted this revision.Aug 25 2023, 1:06 PM
This revision is now accepted and ready to land.Aug 25 2023, 1:06 PM
bartek added inline comments.Aug 25 2023, 1:12 PM
services/backup/src/database/backup_item.rs
34 ↗(On Diff #30328)

btw generate_random_string could be moved to lib someday

services/backup/src/database/log_item.rs
45 ↗(On Diff #30328)

D8936 - it's now in lib and called DDB_ITEM_SIZE_LIMIT

michal added inline comments.Aug 29 2023, 10:53 AM
services/backup/src/database/backup_item.rs
34 ↗(On Diff #30328)

I'm going to move it in another diff (and remove rand dep on backup)

michal updated this revision to Diff 30518.Aug 29 2023, 10:53 AM

Fix constant

Harbormaster completed remote builds in B22233: Diff 30518.Aug 29 2023, 11:11 AM
Closed by commit rCOMM0969a32f4c4c: [backup] Split database module (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM0969a32f4c4c: [backup] Split database module.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
database/
78 lines
105 lines
database/
mod.rs
database.rs
173 lines

Diff 30527

View Options

services/backup/src/database.rs

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

services/backup/src/database/backup_item.rs

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

services/backup/src/database/log_item.rs

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

services/backup/src/database/mod.rs

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }