Paths

Table of Contentst

Differential D8953

[backup] Split database module
ClosedPublic
Actions

Authored by michal on Aug 25 2023, 9:50 AM.

Tags

None

Referenced Files

	F2101527: D8953.id30527.diff
	Mon, Jun 24, 10:32 PM

	Unknown Object (File)
	Sun, Jun 23, 1:22 PM

	Unknown Object (File)
	Wed, Jun 19, 12:32 PM

	Unknown Object (File)
	Sun, Jun 16, 2:09 AM

	Unknown Object (File)
	Thu, Jun 13, 1:22 PM

	Unknown Object (File)
	Mon, Jun 10, 1:16 AM

	Unknown Object (File)
	Fri, Jun 7, 7:12 PM

	Unknown Object (File)
	Sun, May 26, 9:24 AM

View All 73 Files

Subscribers

Details

Reviewers

bartek
• patryk
kamil
• jon

Commits

rCOMM0969a32f4c4c: [backup] Split database module

Summary

ENG-4380
No code changes, just separating code so it's easier to parse.

Test Plan

cargo check

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 25 2023, 9:50 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 25 2023, 9:50 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

michal added a parent revision: D8952: [backup] Introduce backup error.Aug 25 2023, 9:50 AM

michal added a child revision: D8954: [backup] Update dynamodb.Aug 25 2023, 9:54 AM

Harbormaster completed remote builds in B22094: Diff 30328.Aug 25 2023, 10:07 AM

michal requested review of this revision.Aug 25 2023, 10:07 AM

bartek accepted this revision.Aug 25 2023, 1:06 PM

This revision is now accepted and ready to land.Aug 25 2023, 1:06 PM

bartek added inline comments.Aug 25 2023, 1:12 PM

services/backup/src/database/backup_item.rs
34 ↗	(On Diff #30328)	btw `generate_random_string` could be moved to lib someday
services/backup/src/database/log_item.rs
45 ↗	(On Diff #30328)	D8936 - it's now in lib and called `DDB_ITEM_SIZE_LIMIT`

michal added inline comments.Aug 29 2023, 10:53 AM

services/backup/src/database/backup_item.rs
34 ↗	(On Diff #30328)	I'm going to move it in another diff (and remove rand dep on backup)

Fix constant

Harbormaster completed remote builds in B22233: Diff 30518.Aug 29 2023, 11:11 AM

Closed by commit rCOMM0969a32f4c4c: [backup] Split database module (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM0969a32f4c4c: [backup] Split database module.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

database/

78 lines

105 lines

	database/

	mod.rs
	database.rs

173 lines

Diff 30527

services/backup/src/database.rs

Loading...

services/backup/src/database/backup_item.rs

Loading...

services/backup/src/database/log_item.rs

Loading...

services/backup/src/database/mod.rs

Loading...