Differential D8894
[services-lib] Add DDB batch operation helpers Authored by bartek on Aug 22 2023, 12:53 AM. Tags None Referenced Files
Details We use DDB batch operations in several places: reserved usernames write, saving new one-time keys, blob cleanup (soon), reports storage. DDB BatchWriteItem operation API can be cumbersome - 25 items limit, unprocessed items, throttling etc. Their docs also recommend exponential backoff strategy. I decided to create an API that handles all this overhead for us. See also comments in D8452. This diff adds some exponential backoff helpers. See child diff for actual batch_write impl. Tested together with child diff
Diff Detail
Event TimelineComment Actions LGTM, depending on how it is used / if there are going to be non-const-creatable fields in the config in the future, we could consider adding a const default: impl ExponentialBackoffConfig {
const DEFAULT: Self = Self {
max_attempts: 8,
base_duration: std::time::Duration::from_millis(25),
retry_on_provisioned_capacity_exceeded: true,
};
}
impl Default for ExponentialBackoffConfig {
fn default() -> Self {
Self::DEFAULT
}
}so e.g. a service can just create a global const instead of passing the config in some other way. |